Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Property] LocPopNumber no longer needed after merge with property loc file #185

Open
johcarter opened this issue May 23, 2024 · 1 comment
Open

[Property] LocPopNumber no longer needed after merge with property loc file #185

johcarter opened this issue May 23, 2024 · 1 comment
Assignees
@MattDonovan82
Labels
major major release (breaking change)

Comments

@johcarter
Copy link
Contributor

@stufraser1 can you confirm whether the 'LocPopNumber' field is still needed to be included in the spec? Now the LocPopulation file is part of the OED loc file, this looks likes a hangover from when the files were separate that linked the population to the property data? Now they are integrated, does the existing LocNumber field suffice?

Originally posted by @MattDonovan82 in #40
@MattDonovan82 MattDonovan82 self-assigned this May 23, 2024
@johcarter johcarter changed the title LocPopNumber no longer needed after merge with property loc file [Property] LocPopNumber no longer needed after merge with property loc file May 24, 2024
@johcarter johcarter added the major major release (breaking change) label Jun 25, 2024
johcarter added a commit that referenced this issue Jun 26, 2024
@johcarter
#187 #186 #162 #185
53a98de
@MattDonovan82
Copy link
Contributor

I don't think the LocPopNumber is still required in the spec. Agree to remove this field as LocNumber will suffice. @stufraser1 ?

sambles pushed a commit that referenced this issue Jul 17, 2024
@johcarter @sambles
#187 #186 #162 #185
bc06263
sambles pushed a commit that referenced this issue Jul 17, 2024
@johcarter @sambles
#187 #186 #162 #185
442eeb0
@johcarter johcarter mentioned this issue Aug 21, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MattDonovan82 MattDonovan82

Labels
major major release (breaking change)
Projects
OED 4.0.0
Status: Done
Oasis Dev Team Tasks
Status: Done
Open Data Standards
Status: Agreed and ready
Milestone
No milestone
Development

No branches or pull requests
2 participants
@johcarter @MattDonovan82