Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Reinsurance] OriginalCurrency and RateOfExchange fields should not be in ReinsScope file #162

Open
3 tasks
benhayes21 opened this issue Aug 25, 2023 · 0 comments
Assignees
Labels
backlog major major release (breaking change)

Comments

@benhayes21
Copy link
Contributor

Description

OriginalCurrency and RateOfExchange are specified to be present in all 4 OED tables, but there are no fields that they are relevant to in Reinsurance Scope file

Reasons for change

Fields are optional and not used for anything (so should not cause any issues), but their presence in the file is confusing.

Scope of change

  • Location File
  • Accounts File
  • [X ] Reinsurance Scope
  • Reinsurance Info

Impact of change

Optional, non used fields so should not be breaking. Only issues might happen if users have these fields in existing ReinsScope files, which would not be valid in ODS tools after the change

@MattDonovan82 MattDonovan82 added major major release (breaking change) minor minor release (non-breaking change) labels Oct 2, 2023
@johcarter johcarter removed the minor minor release (non-breaking change) label Oct 4, 2023
johcarter added a commit that referenced this issue May 23, 2024
@johcarter johcarter changed the title OriginalCurrency and RateOfExchange fields should not be in ReinsScope file [Reinsurance] OriginalCurrency and RateOfExchange fields should not be in ReinsScope file May 24, 2024
johcarter added a commit that referenced this issue Jun 26, 2024
sambles pushed a commit that referenced this issue Jul 17, 2024
sambles pushed a commit that referenced this issue Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog major major release (breaking change)
Projects
Status: Done
Status: Todo
Status: Agreed and ready
Development

No branches or pull requests

3 participants