Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document the configurations options that enables overwriting values through the web.xml #29

Open
forgedhallpass opened this issue Oct 4, 2021 · 4 comments
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers help wanted Extra attention is needed

Comments

@forgedhallpass
Copy link
Member

Fix the TODO in: org.owasp.csrfguard.config.properties.javascript.JavaScriptConfigParameters

@forgedhallpass forgedhallpass added the documentation Improvements or additions to documentation label Oct 4, 2021
@forgedhallpass forgedhallpass added help wanted Extra attention is needed good first issue Good for newcomers labels Oct 30, 2023
@choichanhyeok
Copy link

Hi @forgedhallpass,

I'm interested in contributing this project, particularly regarding Issue #29. Would it be alright if I worked on this issue?

Looking forward to your guidance.

Thanks,

@forgedhallpass
Copy link
Member Author

Hi @forgedhallpass,

I'm interested in contributing this project, particularly regarding Issue #29. Would it be alright if I worked on this issue?

Looking forward to your guidance.

Thanks,

Hello @choichanhyeok,

Your contribution is welcome. Feel free to start working on it!

@AnmolSirola
Copy link

@forgedhallpass In order to fix this issue we need to write the configurations along with the property names that can be used for overriding their values in the org.owasp.csrfguard.config.properties.javascript.JavaScriptConfigParameters file . Right ?

@forgedhallpass
Copy link
Member Author

forgedhallpass commented Jan 29, 2024

@forgedhallpass In order to fix this issue we need to write the configurations along with the property names that can be used for overriding their values in the org.owasp.csrfguard.config.properties.javascript.JavaScriptConfigParameters file . Right ?

Hello @AnmolSirola,

The property names from theJavaScriptConfigParameters class should be documented in the CSRFGuard properties file, stating that they can be overridden through the web.xml. It's a minor thing really.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants