Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removal of a Parent Permission #87

Open
adamjeff opened this issue Sep 8, 2016 · 8 comments
Open

Removal of a Parent Permission #87

adamjeff opened this issue Sep 8, 2016 · 8 comments

Comments

@adamjeff
Copy link

adamjeff commented Sep 8, 2016

Hi,

You have done a fantastic job with this RBAC library, very impressed!

I do have a question though...

  1. If I choose to remove a Permission for example, which has children/descendants, and choose NOT to remove recursively, what parent ID is then assigned to those children?

  2. Also, I am using jsTree to render the permissions tree which works great. I have provided a drag and drop feature so that a user can easily drag a permission (and all it's children) somewhere else in the tree. What I can't work out though, is how can I update the permission to so it has a new parent (the one just dragged to)? I'm aware of the "edit()" method but that just allows you to update the title and/or description?

Thanks

@abiusx
Copy link
Contributor

abiusx commented Sep 8, 2016

Hello,
I believe they are moved to the parent of the removed permission.
-A

On Sep 8, 2016, at 6:40 AM, adamjeff [email protected] wrote:

Hi,

You have done a fantastic job with this RBAC library, very impressed!

I do have a question though...

If I choose to remove a Permission for example, which has children/descendants, and choose NOT to remove recursively, what parent ID is then assigned to those children?

Thanks


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub #87, or mute the thread https://github.com/notifications/unsubscribe-auth/ABVjW7zwIoYNBoqQyo5wi1Rxsd_BB1zsks5qn-YHgaJpZM4J32dU.

@adamjeff
Copy link
Author

adamjeff commented Sep 8, 2016

Thanks for the response! What do you make of my second question?

@abiusx
Copy link
Contributor

abiusx commented Sep 8, 2016

What second question?

On Sep 8, 2016, at 9:52 AM, adamjeff [email protected] wrote:

Thanks for the response! What do you make of my second question?


You are receiving this because you commented.
Reply to this email directly, view it on GitHub #87 (comment), or mute the thread https://github.com/notifications/unsubscribe-auth/ABVjW-Z835s9ejI26aXS7T-fKAi6zvNbks5qoBM3gaJpZM4J32dU.

@adamjeff
Copy link
Author

adamjeff commented Sep 8, 2016

?? Directly below the first...

  1. If I choose to remove a Permission for example, which has children/descendants, and choose NOT to remove recursively, what parent ID is then assigned to those children?

  2. Also, I am using jsTree to render the permissions tree which works great. I have provided a drag and drop feature so that a user can easily drag a permission (and all it's children) somewhere else in the tree. What I can't work out though, is how can I update the permission to so it has a new parent (the one just dragged to)? I'm aware of the "edit()" method but that just allows you to update the title and/or description?

Thanks

@abiusx
Copy link
Contributor

abiusx commented Sep 8, 2016

I believe there is a move method.
I’m not sure if it is well tested and exported, but I remember I put it there somewhere!
If you could share your interface with the project, we would appreciate it!
-A

On Sep 8, 2016, at 9:54 AM, adamjeff [email protected] wrote:

?? Directly below the first...

  1. If I choose to remove a Permission for example, which has children/descendants, and choose NOT to remove recursively, what parent ID is then assigned to those children?

  2. Also, I am using jsTree to render the permissions tree which works great. I have provided a drag and drop feature so that a user can easily drag a permission (and all it's children) somewhere else in the tree. What I can't work out though, is how can I update the permission to so it has a new parent (the one just dragged to)? I'm aware of the "edit()" method but that just allows you to update the title and/or description?

Thanks


You are receiving this because you commented.
Reply to this email directly, view it on GitHub #87 (comment), or mute the thread https://github.com/notifications/unsubscribe-auth/ABVjW52jjqD28IqkhygZt-YxL8WNp9EJks5qoBN9gaJpZM4J32dU.

@adamjeff
Copy link
Author

adamjeff commented Sep 8, 2016

Yeh sure, no problem!

I can't see any 'move' method in docs? :-/

@abiusx
Copy link
Contributor

abiusx commented Sep 8, 2016

Alright!
Apparently Jesse had reverted the commit that introduced move functionality.
You might wanna try to add it to your code base:
4e1d9e8 4e1d9e8

On Sep 8, 2016, at 9:57 AM, adamjeff [email protected] wrote:

Yeh sure, no problem!

I can't see any 'move' method in docs? :-/


You are receiving this because you commented.
Reply to this email directly, view it on GitHub #87 (comment), or mute the thread https://github.com/notifications/unsubscribe-auth/ABVjW5aJV5dglxDO7fLoL8h1pec_X2IWks5qoBQ0gaJpZM4J32dU.

@adamjeff
Copy link
Author

adamjeff commented Sep 8, 2016

OK cool, I'll give it a go. Let you know if any issues arise!

Thanks again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants