Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: separate resources section for leader and follower #1188

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

feat: separate resources section for leader and follower #1188

wants to merge 1 commit into from
+131 −4

Conversation

husnialhamdani
Copy link
Contributor

Description
separate resources section for leader and follower

Fixes #1186

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • Tests have been added/modified and all tests pass.
  • Functionality/bugs have been confirmed to be unchanged or fixed.
  • I have performed a self-review of my own code.
  • Documentation has been updated or added where necessary.

Additional Context

@codecov Codecov
Copy link

codecov bot commented Dec 24, 2024

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.

Project coverage is 28.97%. Comparing base (60ef5a2) to head (0df4494).
Report is 14 commits behind head on master.

Files with missing lines Patch % Lines
api/v1beta2/zz_generated.deepcopy.go 0.00% 8 Missing and 2 partials ⚠️
pkg/k8sutils/redis-cluster.go 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1188      +/-   ##
==========================================
- Coverage   30.20%   28.97%   -1.23%     
==========================================
  Files          55       56       +1     
  Lines        6294     6495     +201     
==========================================
- Hits         1901     1882      -19     
- Misses       4200     4430     +230     
+ Partials      193      183      -10

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shubham-cmyk shubham-cmyk Awaiting requested review from shubham-cmyk shubham-cmyk will be requested when the pull request is marked ready for review shubham-cmyk is a code owner

@drivebyer drivebyer Awaiting requested review from drivebyer drivebyer will be requested when the pull request is marked ready for review drivebyer is a code owner

@iamabhishek-dubey iamabhishek-dubey Awaiting requested review from iamabhishek-dubey iamabhishek-dubey will be requested when the pull request is marked ready for review iamabhishek-dubey is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Separate resources section for leaders and followers for redis-cluster chart
1 participant
@husnialhamdani