Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Layer Parallelism and Bug fixes for ResNet Halo-D2 #8

Merged
merged 20 commits into from
Aug 15, 2023
Merged

Add Layer Parallelism and Bug fixes for ResNet Halo-D2 #8

merged 20 commits into from
Aug 15, 2023

Conversation

RadhaGulhane13
Copy link
Contributor

No description provided.

@RadhaGulhane13
Cosmetic changes
27f98e4 
Signed-off-by: Radha Guhane <[email protected]>
@RadhaGulhane13
LP for amoebaNet and resNet
7ea08b9 
Signed-off-by: Radha Guhane <[email protected]>
@RadhaGulhane13
code refactoring
bbf1711 
Signed-off-by: Radha Guhane <[email protected]>
@RadhaGulhane13
Refactoring and adding version for black
9bb8d7a 
Signed-off-by: Radha Guhane <[email protected]>
@RadhaGulhane13
Fix ResNet halo-D2 bug
1615663 
Signed-off-by: Radha Guhane <[email protected]>
@RadhaGulhane13 RadhaGulhane13 force-pushed the bug_fixes branch 4 times, most recently from a2e0ebe to 56d97b4 Compare July 7, 2023 17:09
@RadhaGulhane13
Update README.md
5a5f871 
Signed-off-by: Radha Guhane <[email protected]>
@RadhaGulhane13
LP bug fixes
df1cbdd 
Signed-off-by: Radha Guhane <[email protected]>
@RadhaGulhane13
Update Performance Images
256d9ad 
Signed-off-by: Radha Guhane <[email protected]>
@RadhaGulhane13 RadhaGulhane13 requested review from Shetano and aamirshafi and removed request for aamirshafi and Shetano July 14, 2023 01:59
Shetano
Shetano reviewed Jul 21, 2023
View reviewed changes
benchmarks/layer_parallelism/amoebanet_lp.py Outdated Show resolved Hide resolved
benchmarks/spatial/model/amoebanet_run.py Outdated Show resolved Hide resolved
benchmarks/layer_parallelism/amoebanet_lp.py Outdated Show resolved Hide resolved
benchmarks/layer_parallelism/resnet_lp.py Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
setup.py Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here torch-gems or now-dl?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@RadhaGulhane13
Resolve PR comments
7874a06 
- Make dataset path as a argument varaible
- Added benchmarking examples
- Update README.md
- Remove "ResNet" instances from AmoebaNet

Signed-off-by: Radha Guhane <[email protected]>
@RadhaGulhane13 RadhaGulhane13 force-pushed the bug_fixes branch 3 times, most recently from 5b684a5 to bf3cb47 Compare July 25, 2023 08:40
@RadhaGulhane13
Address review changes
b1c036e 
Signed-off-by: Radha Guhane <[email protected]>
RadhaGulhane13 and others added 3 commits July 25, 2023 03:51
@RadhaGulhane13
Cosmetic changes
866285b 
Signed-off-by: Radha Guhane <[email protected]>
@RadhaGulhane13
README.md for halo-exchange
9cf3b92 
Signed-off-by: RadhaGulhane13 <[email protected]>
@RadhaGulhane13
README.md for halo-exchange
01d98a9 
Signed-off-by: RadhaGulhane13 <[email protected]>
@github-actions
Copy link

github-actions bot commented Aug 15, 2023 •
edited
Loading

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.

I have read the CLA Document and I hereby sign the CLA

1 out of 2 committers have signed the CLA.
✅ @Quentin-Anthony
❌ @RadhaGulhane13
You can retrigger this bot by commenting recheck in this Pull Request

@Quentin-Anthony
Copy link
Member

I have read the CLA Document and I hereby sign the CLA

Quentin-Anthony pushed a commit that referenced this pull request Aug 15, 2023
@github-actions
@Quentin-Anthony has signed the CLA in #8
8c0f4ff
@Quentin-Anthony Quentin-Anthony merged commit ca91561 into main Aug 15, 2023
1 of 2 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 15, 2023
@RadhaGulhane13 RadhaGulhane13 deleted the bug_fixes branch August 30, 2023 21:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Shetano Shetano Shetano left review comments

@Quentin-Anthony Quentin-Anthony Awaiting requested review from Quentin-Anthony

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RadhaGulhane13 @Quentin-Anthony @Shetano