Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation changes for get_rank(group) for the 'mpi' and 'nccl' backends #18

Open
RadhaGulhane13 opened this issue Apr 19, 2024 · 0 comments

Comments

@RadhaGulhane13
Copy link
Contributor

Problem :

mcr-dl's support for get_rank(group) doesn't support returning rank with given group, instead it will return world rank.

Description :

  • Take a look at mcr-dl's get_rank(group) implementation for :
  1. mpi backend
    def get_rank(self, group=None):

    int get_rank(int group = 0)
  2. nccl backend
    def get_rank(self, group=None):

    int get_rank(int group = 0)

It take's argument as group but doesn't consider it while retrieving rank w.r.t. given group, instead returns world rank.Implementation support is required to return rank for given group.

Testing :

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant