diff --git a/CHANGELOG.md b/CHANGELOG.md index c03d94f..8de636e 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -11,6 +11,8 @@ before starting to add changes. Use example [placed in the end of the page](#exa ## [Unreleased] +- [#73](https://github.com/OS2Forms/os2forms/pull/73a) + Fix issue with nested elements in webform inherit - [#72](https://github.com/OS2Forms/os2forms/pull/72) Fix certificate testing, also testing for RSA/PEM certs as well as PKCS12 diff --git a/modules/os2forms_forloeb/src/Plugin/EngineTasks/MaestroWebformInheritTask.php b/modules/os2forms_forloeb/src/Plugin/EngineTasks/MaestroWebformInheritTask.php index b04137c..8bd0040 100644 --- a/modules/os2forms_forloeb/src/Plugin/EngineTasks/MaestroWebformInheritTask.php +++ b/modules/os2forms_forloeb/src/Plugin/EngineTasks/MaestroWebformInheritTask.php @@ -2,9 +2,11 @@ namespace Drupal\os2forms_forloeb\Plugin\EngineTasks; +use Drupal\Component\Utility\NestedArray; use Drupal\Core\Form\FormStateInterface; use Drupal\maestro\Engine\MaestroEngine; use Drupal\maestro_webform\Plugin\EngineTasks\MaestroWebformTask; +use Drupal\webform\Entity\Webform; use Drupal\webform\Entity\WebformSubmission; use Drupal\webform\Utility\WebformArrayHelper; @@ -152,9 +154,18 @@ public static function webformSubmissionFormAlter(array &$form, FormStateInterfa if ('webform_submission' === ($entityIdentifier['entity_type'] ?? NULL)) { $submission = WebformSubmission::load($entityIdentifier['entity_id']); $data = $submission->getData(); - foreach ($data as $key => $value) { - if (isset($form['elements'][$key])) { - $form['elements'][$key]['#default_value'] = $value; + + // The target element may be hidden inside sections or field groups + // on the target form. Therefore, we need to load that form and get + // element information to properly set default element values nested + // inside the form. + if ($targetWebform = Webform::load($form['#webform_id'] ?? NULL)) { + foreach ($data as $key => $value) { + if ($targetElement = $targetWebform->getElement($key)) { + if ($element = &NestedArray::getValue($form['elements'], $targetElement['#webform_parents'])) { + $element['#default_value'] = $value; + } + } } } }