subroutine radiation_force_p has an extra loop #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Steven Hahn <[email protected]>
Signed-off-by: Steven Hahn <[email protected]>
Signed-off-by: Steven Hahn <[email protected]>
Signed-off-by: Steven Hahn <[email protected]>
|
Test this please |
Signed-off-by: Steven Hahn <[email protected]>
|
Test this please |
mbeidler3
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing implementation of
subroutine radiation_force_pcontains a loop overparams%pchunkdespite already being called inside a loop overparams%pchunk. There should just be one loop...otherwise it'll only make sense whenpchunk == 1.I tried using !$omp declare simd which requires GCC 12.3 or later.