Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TCPU summary output has intermediate zero values #231

Open
berland opened this issue Jan 16, 2018 · 4 comments
Open

TCPU summary output has intermediate zero values #231

berland opened this issue Jan 16, 2018 · 4 comments

Comments

@berland
Copy link
Member

berland commented Jan 16, 2018

flow outputs TCPU as a summary vector (wall clock time or close to it as a function of simulator date), but values are only printed for report dates, not the intermediate time stepping, like this:

$ summary.x FOO.DATA TCPU
-- Days   dd/mm/yyyy               TCPU 
----------------------------------------
   0.00   01/12/2017                  0 
   1.00   02/12/2017                  0 
   4.00   05/12/2017                  0 
  13.00   14/12/2017                  0 
  31.00   01/01/2018            203.478 
  85.00   24/02/2018                  0 
  93.49   04/03/2018                  0 
 118.95   29/03/2018                  0 
 195.34   14/06/2018                  0 
 320.34   17/10/2018                  0 
 396.00   01/01/2019            665.793 
 521.00   06/05/2019                  0 
 646.00   08/09/2019                  0 
 761.00   01/01/2020            909.397 
 886.00   05/05/2020                  0 
1011.00   07/09/2020                  0 

while not a bug, this tends to plot ugly unless worked around. Eclipse 100 reports TCPU at all these timesteps.

@totto82
Copy link
Member

totto82 commented Jan 16, 2018

I am re-factoring the output code on the simulator side now. Can provide a fix.

@totto82
Copy link
Member

totto82 commented Jan 16, 2018

Fix provided in OPM/opm-simulators#1384

@joakim-hove
Copy link
Member

As implicitly indicated by the patch from @totto82 this is not really a problem with the output module; that module is not very capable - just passing the values it receives from the simulator to a suitable formatted output file. Hopefully OPM/opm-simulators#1384 solves it.

@totto82
Copy link
Member

totto82 commented Jan 17, 2018

Unfortunately OPM/opm-simulators#1384 does not solve the issue. The problem is that the simulator only count time between report steps. We simply need to start and stop the timer within substeps. Shouldn't be to complicated to fix but it deserves a PR on its own.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants