Skip to content

BrowseResultMask includes "odd" enum values #135

Open
@jouniaro

Description

@jouniaro
public enum BrowseResultMask implements Enumeration {

    None(0),
    ReferenceTypeId(1),
    IsForward(2),
    NodeClass(4),
    BrowseName(8),
    DisplayName(16),
    TypeDefinition(32),
    All(63),
    ReferenceTypeInfo(3),
    TargetInfo(60);

The last 3 values are bit sets, instead of enum values and don't belong there. Also None is useless. We have constants for the sets already and could define the other sets similar ways:

	public static EnumSet<BrowseResultMask> NONE = EnumSet.noneOf( BrowseResultMask.class );
	public static EnumSet<BrowseResultMask> ALL = EnumSet.allOf( BrowseResultMask.class );

The problem is that these are generated from the UA Defined Types.xml, which is defining the bit sets as well, so they should be removed from there in practice.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions