Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BrowseResultMask includes "odd" enum values #135

Open
jouniaro opened this issue Apr 20, 2018 · 0 comments
Open

BrowseResultMask includes "odd" enum values #135

jouniaro opened this issue Apr 20, 2018 · 0 comments
Milestone

Comments

@jouniaro
Copy link
Contributor

public enum BrowseResultMask implements Enumeration {

    None(0),
    ReferenceTypeId(1),
    IsForward(2),
    NodeClass(4),
    BrowseName(8),
    DisplayName(16),
    TypeDefinition(32),
    All(63),
    ReferenceTypeInfo(3),
    TargetInfo(60);

The last 3 values are bit sets, instead of enum values and don't belong there. Also None is useless. We have constants for the sets already and could define the other sets similar ways:

	public static EnumSet<BrowseResultMask> NONE = EnumSet.noneOf( BrowseResultMask.class );
	public static EnumSet<BrowseResultMask> ALL = EnumSet.allOf( BrowseResultMask.class );

The problem is that these are generated from the UA Defined Types.xml, which is defining the bit sets as well, so they should be removed from there in practice.

@bjakke bjakke added this to the 1.4.1 milestone Nov 13, 2018
@bjakke bjakke modified the milestones: 1.4.1, 1.4.2 Dec 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants