RestrictedFunctionSpace: Added in changes to Dataset / Set for use in RestrictedFunctionSpace in firedrake #716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dham
requested changes
Feb 28, 2024
emmarothwell1
force-pushed
the
emmarothwell1/restricted_function_space_review
branch
from
fe848d7
to
7c64679
Compare
emmarothwell1
commented
Apr 25, 2024
dham
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is a part of the following pull request: https://github.com/firedrakeproject/firedrake/pull/3426
This gives sets an additional size, called constrained size. This is then used to create the correct layout_vec for restricted spaces.
There's also some signature data being passed through the global kernel as well to distinguish between restricted and unrestricted spaces.