Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows support #43

Open
listepo opened this issue Jan 24, 2024 · 7 comments
Open

Windows support #43

listepo opened this issue Jan 24, 2024 · 7 comments
Labels
help wanted Extra attention is needed

Comments

@listepo
Copy link

listepo commented Jan 24, 2024

It would be nice to have support for MacOS and Windows

@ospfranco
Copy link
Contributor

macos is already supported. I don't know how windows modules work, so PRs are welcome

@listepo
Copy link
Author

listepo commented Jan 24, 2024

@ospfranco https://github.com/microsoft/react-native-windows-samples/tree/main/samples/NativeModuleSample/cppwinrt Can this example help? Sorry, I don't know C++ well enough

@ospfranco
Copy link
Contributor

No idea buddy. I will probably not do this myself, no free time atm. Somebody else will have to take care of it.

@ospfranco ospfranco added the help wanted Extra attention is needed label Jan 24, 2024
@polar-sh polar-sh bot added the Fund label Feb 28, 2024
@ospfranco ospfranco changed the title Support for MacOS and Windows Windows support Apr 23, 2024
@maksimlya
Copy link

@ospfranco any idea how much work is to add windows support?

@ospfranco
Copy link
Contributor

Nope, I have never developed for windows

@ospfranco ospfranco removed the Fund label Jun 3, 2024
@maksimlya
Copy link

maksimlya commented Jun 27, 2024

@ospfranco Hi, I can try adding windows support. Can you tell me how you built the jni libs(android), .a files(ios)? I noticed you have 2 versions, I did not find any make files.

@ospfranco
Copy link
Contributor

Before you start developing this, I hope you realize will have to maintain the Windows versions for ever. The moment I change the API or do some breaking change I will not even try to take a look and try to make it work.

That being said, for any existing library file in the repo. You need to compile it in their source repo and then drop them here. You will probably need to compile crsqlite and libsql. crsqlite I cannot help, I just found some prebuilt binary and dropped it in the repo. For libsql turso paid me for development time to port to mobile platforms. Here are the instructions (link to the PR is inside) on how to compile libsql for mobile targets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants