Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xpress Baazaar ( SA : RET11) - Compliance Check #2546

Open
Jagannath-wits opened this issue Sep 29, 2024 · 3 comments
Open

Xpress Baazaar ( SA : RET11) - Compliance Check #2546

Jagannath-wits opened this issue Sep 29, 2024 · 3 comments

Comments

@Jagannath-wits
Copy link

Jagannath-wits commented Sep 29, 2024

Flow 1

On Search

  • default_selection and lower.range is not correctly calculated for the item_id : ‘7a1eb7d6-c522-5a69-936d-b9ebbaf88869’. Kindly check for others as well or please explain the calculation.
  • Invalid/Placeholder values, eg: fssai licence number, description, etc should not be provided
  • Circle radius should be 500 kms max even if serviceability is PAN india
  • The veg can’t be ‘yes’ for the non-veg customisation for id : ‘C16’. Kindly check for others

Flow 2

On Confirm

  • order.created_at timestamp mismatches in /confirm and /on_confirm
  • fulfillment.ranges would only be provided once the ‘Order’ is Accepted. How are you providing ranges before order is accepted ?

On Status Picked

  • If ‘url_enabled’ is no then the ‘url’ field must not be provided
  • invoice is not publically accessible

Flow 3

  • Same as Flow 2

On Select Out Of Stock

  • In your case the customization out of stock, and this is incorrect way of providing it. Kindly refer to page no 222 of the Retail Contract; you should also provide the dynamic_item_id along with it. Eg: {"dynamic_item_id":"DI2","customization_id":"C15","customization_group_id":"CG3","error":"40002"}]

Flow 4

  • Same as Flow 2

On Cancel

  • Why are the ‘Delivery Charges’ are being charged when the order is cancelled pre-shipment ?

Flow 5

  • Same as Flow 2

On Cancel

  • RTO start timestamp is missing in the ‘RTO’ fulfilment

on_status_rto_disposed

  • cancellation object not carried forward from on_cancel.
  • rto_fulfillment.end.time.range is not required.

Flow 6

  • Same as Flow 2

On Update Partial Cancel

  • order.state shouldn't be changed from Created to Accepted in /on_update_part_cancel
  • If the quote_trail for the id : ‘a650004’ is 0,then it shouldn’t be provided in the quote_trail

Update Settlement Partial Cancel

  • The timestamp of update settlement is greater than the on_status_pending

On Status Pending

  • Update Settlement of the partial cancellation is not carried forward
  • Why the start.timestamp is there for ‘Delivery’ fulfilment as the ‘Order’ is not yet picked up

On Status Packed

  • Mismatch occurred while comparing 'Delivery' fulfilment object with on_status_pending on key 'start/time'

On Status Delivered

  • The end.timestamp is missing for ‘Delivery’ fulfillment

on Update return initiated

  • How are settlement details of part-cancell provided before it was sent from buyer?
  • Manual manipulation of logs are not allowed

On Update Interim

  • The forward fulfilment item should be reduced in on_update_liquidated and return fulfillment
    should be created in on_update liquidated action call
  • quote and item quantity shouldn’t be reduced in the iterim action call for liquidated

On Update Liquidated

  • quote_trail is not captured for the return request
  • How the update settlement is future dated ?

@purushottamKj
- Please run the utility for flow 6 as well
Manual manipulation of logs are not allowed

@purushottamKj
Copy link
Contributor

@Jagannath-wits
FLOW 2,3,4,5,6 : Mismatch found for item with item_id 7a1eb7d6-c522-5a69-936d-b9ebbaf88869 while comparing quote object of on_select and confirm.
as you have asked how is the parent_item_id is different
the reason for that we have order same product with different customised way
As per the docs, parent_item_id will be different.

@Jagannath-wits
Copy link
Author

@Jagannath-wits FLOW 2,3,4,5,6 : Mismatch found for item with item_id 7a1eb7d6-c522-5a69-936d-b9ebbaf88869 while comparing quote object of on_select and confirm. as you have asked how is the parent_item_id is different the reason for that we have order same product with different customised way As per the docs, parent_item_id will be different.

ok then that is fine, please proceed with others

@FarheenNazQA
Copy link

Flow 1

On Search

upper range is not collected properly for the item_id : ‘7a1eb7d6-c522-5a69-936d-b9ebbaf88869’.Kindly check for others as well or please explain the calculation.

Custom groups having min- 1 in config should have at least one default.eg - CG3.

Flow 2

On Status Pending

How the ranges for the start and end object is same ?

Flow 4

On Cancel

if the quote_trail price is ‘0’, It must not be provided in the ‘Cancel’ Object
Quote trail for ‘Delivery’, ‘Packing’ charges, Convenience Fee are not there
subtype should be used in the quote_trail in case of customization and customized item

Flow 6

On Update Part Cancel

Delivery fulfilment state descriptor is an empty object
quote_trail price and item quote price sum for on_update should be equal to the price as in on_confirm.

On Status Picked

Invoice doesn’t match with the given quote price.

On Update Liquidated

No changes detected in items and quote.price. On what basis are you doing doing the liquidation and providing quote_trail ?

@purushottamKj

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants