Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gofrugal (SA:RET16) - Compliance Check #2513

Open
sahil-ondc opened this issue Sep 25, 2024 · 2 comments
Open

Gofrugal (SA:RET16) - Compliance Check #2513

sahil-ondc opened this issue Sep 25, 2024 · 2 comments

Comments

@sahil-ondc
Copy link

Flow 1

on_search (full catalog)

  • @ondc/org/return_window can’t be ‘P0D’ as it also serves as IGM window
  • maximum.count value can’t be greater than ’99’ or it can be a realistic value
  • /message/catalog/bpp~1providers/0/categories/0/id must match pattern "^[a-zA-Z0-9-]{1,12}$\

on_search (inc catalog)

  • Only objects with changes should be populated in on_search_inc, there seems to be no change in categories object

@logeshkumar.t

@logeshthiru
Copy link
Contributor

logeshthiru commented Sep 25, 2024

on_search (full catalog)

1.@ondc/org/return_window can’t be ‘P0D’ as it also serves as IGM window

  • In Retail v1.2 api contract which is not mentioned and it is not returnable so that we have sent that 'P0D'.
  1. maximum.count value can’t be greater than ’99’ or it can be a realistic value
  • We will fix this and update.

3./message/catalog/bpp~1providers/0/categories/0/id must match pattern "^[a-zA-Z0-9-]{1,12}$\

-This changes have high impact at our end, is this mandatory?

on_search (inc catalog)

1.Only objects with changes should be populated in on_search_inc, there seems to be no change in categories object

@sahil-ondc
Copy link
Author

Flow 1

On Search

  • /message/catalog/bpp~1providers/0/categories/0/id must match the pattern "^[a-zA-Z0-9-]{1,12}$".
  • '@ondc/org/fssai_license_no' is not required in the bpp/providers for RET16.
  • The circle radius should be a maximum of 500 km, even if serviceability is PAN India.
  • The image provided for the item_id: '20225-ONDC-1-26-26_2_conv' is not related to the item. Kindly check for others as well.
  • How can the weight of an item be 1 gram? Could you please justify this for item_id: '20225-ONDC-1-26-26_2_conv'?
  • The 'back_image' is not provided in the tags for item_id: '20225-ONDC-1-27-27_5_conv', even though it is mentioned to refer to the 'back image' for the 'manufacturer_or_packer_address'. Kindly check for others as well.
  • The tags.serviceability value can't exceed 500 km.

On Search

  • An empty categories object cannot be present in the incremental action call for on-search.

@logeshthiru

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants