Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nearshop (SA:RET14) - Compliance Check #2502

Open
Jagannath-wits opened this issue Sep 24, 2024 · 1 comment
Open

Nearshop (SA:RET14) - Compliance Check #2502

Jagannath-wits opened this issue Sep 24, 2024 · 1 comment

Comments

@Jagannath-wits
Copy link

Jagannath-wits commented Sep 24, 2024

Flow 1

on_search

  • ROM and storage for a phone are usually the same so its value would be same, false information should not be provided regarding the product
  • placeholder images should not be provided
  • variant declared should be for same same item. Eg: iphone 14 and iphone15 are different items altogether and can’t be variants based on colour.
  • timing object not captured properly, as the timing is provided as frequency in locations.time.schedule there will be 2 timings objects in tags with different time_from(starting time) and time_to(starting time + frequency) .
  • also timings object time_from and time_to should not coincide.

Inc_on_search

  • return_window can’t be null
  • items.descriptor.code can’t be null
  • parent_item_id missing

@RonitKumarSinha

@sahil-ondc
Copy link

RET 14

On Search

  • /bpp/providers[0]/locations/area_code doesn't match with the gps
  • tags.timing doesn’t match with the given location/time/range
  • times and frequnency will be provided or time.ranges will be provided in the locations, both can’t be there

On Search Inc

  • ROM and storage for a phone are usually the same so its value would be same, false information should not be provided regarding the product

@RonitKumarSinha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants