ENAM (BA:RET10) - Compliance check

[Jagannath-wits]

ENAM-Buyer

Buyer should send Nack whenever audit trail is broken and/or invalid payload is provided

Flow-1

Search

• Will you not be charging the buyer finder fee for the app?

On_search

• Category id Beverages, Foodgrains is deprecated, please refer to the sheet for updated categories.
• Items.descriptor.code should be 1:EAN and not 4:HSN.
• Holiday shouldn’t be past-dated.

---

Flow-2

On_init

• tax_number should be validated, and nack should be sent for an invalid tax_number.

On_confirm

• /message/order/fulfillments/0/end must have the required property person.

On_status_picked

• Tags are mandatory in Delivery Fulfillment.
• How was the data added/removed in on_status that wasn't present in On_confirm?
  Example: message/order.fulfillments/0/end/person (contact, start/contact, start/location).

On_status_delivered

• The timestamp for the /on_confirm API cannot be greater than or equal to the /on_status_delivered API.
• Tags are mandatory in Delivery Fulfillment for on_status_delivered.
• order.updated_at timestamp should be less than or equal to context.timestamp for /on_status_delivered API.
• The delivery timestamp should be less than or equal to context.timestamp and can't be future-dated, as this on_status is sent after the product is delivered. Example: the delivery timestamp is 2024-09-03T12:23:29.617Z, and the context timestamp is 2024-09-03T12:16:19.760Z.
• order.updated_at timestamp can't be future-dated (should be less than or equal to context.timestamp).
• Mismatch occurred while comparing the 'Delivery' fulfillment object with on_confirm on keys (end/person, end/contact, start/contact, start/location).

---

Flow-04

On_status

• The on_status timestamp would be greater than the status timestamp i.e if a status call is provided its subsequent on_status should also be provided.

On_cancel

• Delivery charges shouldn’t be applied as the order was canceled in pre-shipment.

---

Flow-6

Questions

• Why is part-cancel not provided?
• Why are fulfillments also provided in update_settlement when the update target is the payment object?
• The buyer app should send nack when the audit trail is not maintained (i.e., the settlement details are not carried forward after update_settlement).

@vishalbitxia

[vibhav-bitxia]

Flow 1

Search

• Will you not be charging the buyer finder fee for the app?

Buyer finder fee is zero for eNAM seller app as per SFAC

Flow 6

Questions

• Why are fulfillments also provided in update_settlement when the update target is the payment object?

According to API Contract, both fulfillment and payment object are provided.

For all the "On" calls we have used Addble as the seller app and eNAM buyer app so the issue pertains at Addble seller's end. Please let us know what to do in this case?

@Jagannath-wits @sandeepshahi Please review our comments and provide your inputs

[sahil-ondc]

Flow 1

On Search

• /message/catalog/bpp~1providers/0/categories/0/id must match pattern "^[a-zA-Z0-9-]{1,12}$"
• code should have 1:EAN as a value in /message/catalog/bpp/providers[0]/items[0]/descriptor/code
• Holidays cannot be past 2024-10-04
• ‘Beverages’ and ‘Foodgrains’ category_ids are depreciated and is not allowed in bpp/providers

Search inc

• context/city should be "*" while sending search_inc_catalog request

On Search Inc

• bpp/descriptor sent in payload shouldn’t be part of /on_search_inc_refresh action call
• tags, fulfillments and descriptor are not required in the bpp/provider
• bpp/fulfillments sent in payload shouldn’t be part of /on_search_inc_refresh api
• invalid key found “0” in the item_id : ‘m03fSh4Y66hqVyBJJS0K’
• maximum and available count can’t exceed ’99’. It can be either ’99’ or a realistic value
• location label (/bpp/providers/locations/time/label) for /on_search_inc_refresh should not be equal to /on_search_full_catalog_refresh.label

Flow 2

Init

• payment object is not allowed in init action call
  
### On Init
- Invalid format for tax_number in on_init

Confirm

• How ‘@ondc/org/TAT’ is changed from ‘P2DT3H’ to ‘PT48H’

On Confirm

• When the onConfirm Order State is 'Accepted', the on_status_pending is not required!
• /message/order/fulfillments/0/end must have required property 'person'

On Status Packed

• Mismatch occurred while comparing 'Delivery' fulfillment object with on_confirm on key 'end/person'
• Mismatch occurred while comparing 'Delivery' fulfillment object with on_confirm on key 'end/contact' as field ‘email’ is added later on
• Mismatch occurred while comparing 'Delivery' fulfillment object with on_confirm on key 'start/contact' as field ‘email’ is added later on


On Status Picked

• Tags are mandatory in Delivery Fulfillment.

Flow 4

On Cancel

• Delivery charges shouldn’t be applied as the order was canceled in pre-shipment.

Flow 5

On Cancel

• fulfillment type delivery end/contact/email is missing in /on_cancel

On Status RTO Delivered

• /context must have required property 'ttl'
• fulfillment type delivery end/contact/email is missing in /on_status_rto_delivered
• Delivery fulfillment start location id missing in on_status_rto_delivered/disposed
• images were not present in the On_cancel action call in the delivery fulfillment descriptor

Flow 6

On Update Part Cancel

• item_id : ‘YZ7POp3Tvr0QmEoiQQ5c’ is missing in the quote.breakup

On Update Picked

• item_id : ‘Yeqi3zvGLMmUfksLWEsU’ is missing in the quote.breakup

On Update Liquidated

• item_id : ‘EaTj7NhXwzQgH8zVtRRG’ is missing in the quote.breakup

@vishalbitxia

[vibhav-bitxia]

Hi @sahil-ondc
Comments provided on all the "on" calls are related to Addble seller app and it can't be fixed at our end.
We will be fixing the non-"on" calls issues and submit only the flows in which we have received comments on eNAM buyer app.
Please provide your approval on the same. Also, please let us know if you have any suggestion or query regarding the same.