Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce english locale when writing unique fraction cells #368

Merged
merged 5 commits into from
Sep 28, 2023
Merged

Enforce english locale when writing unique fraction cells #368

merged 5 commits into from
Sep 28, 2023

Conversation

thoniTUB
Copy link
Contributor

This is the easiest way to fix #367, i guess.

@thoniTUB thoniTUB mentioned this pull request Feb 10, 2023
Open
@MaximMoinat MaximMoinat changed the base branch from master to develop February 13, 2023 18:42
@MaximMoinat MaximMoinat self-requested a review February 13, 2023 18:43
MaximMoinat
MaximMoinat approved these changes Feb 13, 2023
View reviewed changes
Copy link
Collaborator

@MaximMoinat MaximMoinat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Changed target branch to develop, which also pulled in some documentation changes.
Thanks for providing the fix!

@thoniTUB
Copy link
Contributor Author

Super, happy to help!

@janblom janblom merged commit a7eb531 into OHDSI:develop Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janblom janblom janblom approved these changes

@MaximMoinat MaximMoinat MaximMoinat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ScanReport cannot be used for fake-data-generation or rabbit-in-a-hat
4 participants
@thoniTUB @janblom @MaximMoinat @watilde