[GL3+] Do not force-enable Depth Clamp

darksylinc · darksylinc · commit d18a9c991fa9 · 2021-07-24T18:45:29.000-03:00
RenderSystem::setClipPlanes is a legacy function that no one is using. However setClipPlanes would get called because mClipPlanesDirty starts as true; which causes a lot of problems (e.g. see gazebosim/gz-rendering#365) Proper depth clamp support was added in Ogre 2.3 Not using depth clamp is consistent with all other RenderSystems anyway
diff --git a/RenderSystems/GL3Plus/src/OgreGL3PlusRenderSystem.cpp b/RenderSystems/GL3Plus/src/OgreGL3PlusRenderSystem.cpp
@@ -3701,7 +3701,6 @@ namespace Ogre {
 
     void GL3PlusRenderSystem::setClipPlanesImpl(const Ogre::PlaneList& planeList)
     {
-        OGRE_CHECK_GL_ERROR(glEnable(GL_DEPTH_CLAMP));
     }
 
     void GL3PlusRenderSystem::registerThread()

Original file line number	Diff line number	Diff line change
`@@ -3701,7 +3701,6 @@ namespace Ogre {`
`3701`	`3701`
`3702`	`3702`	`void GL3PlusRenderSystem::setClipPlanesImpl(const Ogre::PlaneList& planeList)`
`3703`	`3703`	`{`
`3704`		`- OGRE_CHECK_GL_ERROR(glEnable(GL_DEPTH_CLAMP));`
`3705`	`3704`	`}`
`3706`	`3705`
`3707`	`3706`	`void GL3PlusRenderSystem::registerThread()`