Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need version for VS2017 #51

Closed
Mech0z opened this issue Feb 27, 2017 · 18 comments
Closed

Need version for VS2017 #51

Mech0z opened this issue Feb 27, 2017 · 18 comments
Assignees

Comments

@Mech0z
Copy link

Mech0z commented Feb 27, 2017

Any plans for supporting VS 2017 ? I tried opening the Vsix and changing to version 15, but that didnt work

@fileman
Copy link

fileman commented Mar 15, 2017

Hi, I've forked this repo and updated references and the vsixmanifest and now I can install and run in VS2017, but only for ODataV4.
Waiting official release of this extension and RESTier stable.
Use at your own risk and possible license violation.

@robsiera
Copy link

robsiera commented Apr 13, 2017

@fileman, your ODataV4-only was a showstopper for me. Hence my fork which still supports v1-v4. Thanks for showing me the road. Couldn't have done it as fast without your fork as an example.

@fileman
Copy link

fileman commented Apr 13, 2017

The beauty of open source, thanks @robsiera
Since your fork supports OData V1-V4, make a PR to main branch!

@Mech0z
Copy link
Author

Mech0z commented Apr 18, 2017

@robsiera I still get http://i.imgur.com/9Tn75KZ.png when I try to "Update service reference" in VS2017 if I compile your version, is there something else that needs to be changed for that to work?

@robsiera
Copy link

@Mech0z You compiled the code in Release build? You uninstalled any previously installed vsix of Microsoft.OData.ConnectedService? You installed the \ODataConnectedService\src\bin\Release\Microsoft.OData.ConnectedService.vsix ?

Here my Release files

@Mech0z
Copy link
Author

Mech0z commented Apr 19, 2017

@robsiera Tried your release file, uninstalled my own and installed that one, but still gets the same error. Is there a log printed somewhere with a more detailed error?

@robsiera
Copy link

robsiera commented Apr 19, 2017

@Mech0z Did you follow the instructions "Generate Client Proxy" at the end of this page?

@Mech0z
Copy link
Author

Mech0z commented Apr 19, 2017

@robsiera Ah my bad, I thought I could reuse my existing Service reference and just do "update service reference" but if I added it as a Connected service instead it worked fine. Is there any major difference between the 2 types?

@robsiera
Copy link

no difference at all.

@Mech0z
Copy link
Author

Mech0z commented Apr 19, 2017

@robsiera Okay, could hope for better git merge support :) we always gets merge conflicts if one person have added 1 property or class to the reference

@aferreira44
Copy link

Thanks for the VS 2017 version but I get this error (https://snag.gy/tSZWjU.jpg) when I try update my old connected service or create a new one. Any idea to solve this?

@estiller
Copy link

Wow, it's July already and the PR is still not merged in yet?
#53

@robsiera Thanks for your work! I managed to install it successfully in VS2017.

@martinholden-skillsoft
Copy link

@aferreira44 I forked @robsiera code and fixed this issue. It was because the v3codegen had a dependency on the WCF Data Services been installed.

Here is the blame

@nla-brandonjames
Copy link

@martinholden-skillsoft This is great! I don't know how to build this project but I do get the same error when I use the extension, trying to access data from the official OData sample server. I was hoping that if I ever got the SAP OData server we have on site working this would still happen. By the way, would you know how to fix this error of mine? #56. I don't know if it has something to do with an invalid ssl cert or not. I can't find where in the code the message is generated from.

@nla-brandonjames
Copy link

nla-brandonjames commented Aug 11, 2017

Alright, I did build and install this solution, and I got one step closer to generating the code, but I got stuck with a new error.

Screenshot

Even after I manually remove these from a file, it still gives me issues with things not being defined in the namespace...

@AlanWong-MS AlanWong-MS self-assigned this Aug 23, 2017
@AlanWong-MS
Copy link
Contributor

image

Hi everyone, we've been busy with transitions, ramp-ups, and housecleaning during the past months, and now, we're going to work on this. Thanks for your patience!

@AlanWong-MS
Copy link
Contributor

I reviewed @robsiera's PR #53 and it installed fine on my VS2017. I'll be consolidating issues via that PR. Please feel free to add input there.

@AlanWong-MS
Copy link
Contributor

AlanWong-MS commented Aug 31, 2017

Addressed with PR #62! Please take a look at the Marketplace for the updated extension that should now support VS2017. Thank you for your support!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants