From 087ea08d0c43b1ef2d54e4ef65d6a4fd4ebeec89 Mon Sep 17 00:00:00 2001 From: Carlos Roca Date: Thu, 8 Aug 2024 08:02:39 +0200 Subject: [PATCH] [FIX] web_widget_numeric_step: Remove focus to avoid annoying flickering effect The focus introduced on the 16.0 migration is causing a flickering effect that is a bit annoying and does not make complete sense, because if you click more than once the cursor is positioned at the end of the text, which makes it difficult to edit the input. The counterpart of these changes is that to edit the input using the keyboard we will have to click on the field. Although this is how the module has been operating since its inception. --- web_widget_numeric_step/static/src/numeric_step.esm.js | 5 ----- 1 file changed, 5 deletions(-) diff --git a/web_widget_numeric_step/static/src/numeric_step.esm.js b/web_widget_numeric_step/static/src/numeric_step.esm.js index 1522132d26c7..94ef3b48ccd0 100644 --- a/web_widget_numeric_step/static/src/numeric_step.esm.js +++ b/web_widget_numeric_step/static/src/numeric_step.esm.js @@ -4,17 +4,12 @@ import {registry} from "@web/core/registry"; import {standardFieldProps} from "@web/views/fields/standard_field_props"; import {_lt} from "@web/core/l10n/translation"; import {FloatField} from "@web/views/fields/float/float_field"; -import {hasTouch} from "@web/core/browser/feature_detection"; export class NumericStep extends FloatField { setup() { super.setup(); } _onStepClick(ev) { - const $el = $(ev.target).parent().parent().find("input"); - if (!hasTouch()) { - $el.focus(); - } const mode = $(ev.target).data("mode"); this._doStep(mode); }