Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mechanism to fail on WARNING messages in Odoo test log #10

Closed
sbidoul opened this issue Aug 31, 2021 · 8 comments
Closed

Add mechanism to fail on WARNING messages in Odoo test log #10

sbidoul opened this issue Aug 31, 2021 · 8 comments
Labels
enhancement New feature or request

Comments

@sbidoul
Copy link
Member

sbidoul commented Aug 31, 2021

No description provided.

@rousseldenis
Copy link

Complementary of this, it should be great to have that level on check status : community/community#11592

@sbidoul
Copy link
Member Author

sbidoul commented Jun 23, 2024

Now that checklog-odoo is a standalone project, we can progress with this.

checklog-odoo can be installed with pipx in the Dockerfile.

One way to approach this is to add an OCA_ENABLE_CHECKLOG_ODOO environment vairable and an oca_checklog_odoo script. If that variable is set, the script runs checklog-odoo. If not set, the script run checklog-odoo -i ".*" to ignore all warnings`.

oca_init_test_database and oca_run_tests can then be adapted to pipe into oca_checklog_odoo.

@rousseldenis
Copy link

@sbidoul A POC on what can be the mechanism : OCA/stock-logistics-workflow#1632

@sbidoul
Copy link
Member Author

sbidoul commented Sep 12, 2024

@rousseldenis yes, I've seen that one. But I think the approach I outlined above will be simpler.

@rousseldenis
Copy link

@rousseldenis yes, I've seen that one. But I think the approach I outlined above will be simpler.

Yes, but the difference is that main tests will fail, correct ?

@sbidoul
Copy link
Member Author

sbidoul commented Sep 12, 2024

Yes, that's the point. I think the vast majority of warnings reveal real bugs that need to be resolved, and there is a way to ignore some with checklog-odoo config if needed.

@rousseldenis
Copy link

Yes, that's the point. I think the vast majority of warnings reveal real bugs that need to be resolved, and there is a way to ignore some with checklog-odoo config if needed.

Ok, I +100 for that

@sbidoul
Copy link
Member Author

sbidoul commented Sep 30, 2024

Done in #77

@sbidoul sbidoul closed this as completed Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants