Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure out access to repos and build runs #5

Open
matentzn opened this issue May 23, 2019 · 8 comments
Open

Figure out access to repos and build runs #5

matentzn opened this issue May 23, 2019 · 8 comments

Comments

@matentzn
Copy link
Collaborator

Thanks :)

@matentzn
Copy link
Collaborator Author

Sorry, new to Jenkins. In the absence of a way to automatically trigger a build when MP changes, how can I manually trigger a Jenkins build?

@kltm
Copy link
Contributor

kltm commented May 23, 2019

(Done.)
We can discuss this and get to where we need to be. Various combinations of possibilities:

  1. Everybody gets access to Jenkins as part of this new pattern.
  2. You get access cause you're you.
  3. We get Jenkins to run periodically.
  4. We set Jenkins to scan for branches (and changes on them)
  5. We set Jenkins to look for PRs.
  6. Look at other triggers (different webhooks, etc.)

Also tagging @cmungall

@matentzn
Copy link
Collaborator Author

matentzn commented May 24, 2019

Everybody gets access to Jenkins as part of this new pattern.

Everybody sounds excessive.. I do not like the idea. If we cant give per job credentials easily, maybe we should not give any..

You get access cause you're you.

Is only very short term solution and won't really help with my problem :)

We get Jenkins to run periodically.

I don't think that is enough, unless its hourly, which is very resource intensive (think CO2)

We set Jenkins to scan for branches (and changes on them)

My personal favourite - but probably the hardest to do.

We set Jenkins to look for PRs.

Not enough; too many people commit to Master and dont bother with PRs.

Look at other triggers (different webhooks, etc.)

I think the only to long term options are: scan for changes to branches or give credentials to stop and start a job on a per-build-pipeline basis.. Don't know which is better/less work..

A fake-it-till-you-make-it approach would be: trigger the build by changing this here repository; maybe that is easier and we can use the github permission system to give people access to trigger a build. For example, we could give MP guys edit rights to this here repo, and they simply trigger an arbitrary change (adding a space to a readme file, documenting something), to trigger of the jenkins build.. :P

@kltm kltm changed the title Can I get write access to this repo? Figure out access to repos and build runs May 24, 2019
@kltm
Copy link
Contributor

kltm commented May 24, 2019

Okay, I believe this is what we should now have:

  • The OBOFoundry organization is scanned every 15m for changes to a named branch with a Jenkinsfile in the top-level directory.
  • If a new one is found, it will run
  • If there is a change to one, it will run
  • If changes occur to a repository within a fifteen minute window when a build is already underway, they will be ignored (quite period matching the scan period)
  • One can manually override the above

We can (and probably should) add the ability to do things manually for users who want to. How that is organized, I do not know.

@cmungall
Copy link

Can we add obophenotype as another org to scan? After that I believe this repo can go away

@kltm
Copy link
Contributor

kltm commented May 24, 2019

@cmungall
https://github.com/obophenotype ?
To make debugging/setup easier, you may want to add me.
To clarify, scan that repo and cease scanning the OBOFoundry repo? What of the mp job?

@cmungall
Copy link

We'll move the mp job - either to existing mp repo or just mv the repo

Caveat: I may not be aware of all the implications of doing this across different orgs

You have an invite

@kltm
Copy link
Contributor

kltm commented May 24, 2019

Scanned, only found pipeline-mp in the new org.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants