Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Current, can't "grab" the model on a feature #1

Open
Tracked by #12
tomatenhans opened this issue Sep 15, 2023 · 4 comments
Open
Tracked by #12

Current, can't "grab" the model on a feature #1

tomatenhans opened this issue Sep 15, 2023 · 4 comments
Assignees

Comments

@tomatenhans
Copy link
Contributor

tomatenhans commented Sep 15, 2023

Needs to be further discussed

@h3ssto
Copy link

h3ssto commented Oct 12, 2023

This works in the viewer in comvy 🤔 @tomatenhans @LukasOsti Probably, you two should compare the mouse bindings.

@h3ssto h3ssto assigned SunVal and unassigned h3ssto Oct 30, 2023
@h3ssto
Copy link

h3ssto commented Oct 30, 2023

dragAndDrop.service.js has empty diff in both variability.dev and comvy

@SunVal
Copy link
Contributor

SunVal commented Nov 1, 2023

since the current version supports "non-semantic editing" (dragging nodes to change the order of sister nodes) by default the only draggable node to move the feature model would be the root node.
Therefore, a new option to disable non-semantic editing should be added, so that dragging the feature model works on every node.

@SunVal SunVal transferred this issue from OBDDimal/variability.dev-database Nov 2, 2023
@h3ssto
Copy link

h3ssto commented Nov 11, 2023

As discussed, there are now 3 modes for dragging of nodes:

  • Default: moves the FM
  • Non-semantic editing toggled on: Lateral movement of siblings
  • Semantic editing toggled on: Arbitrary movement of siblings
    • Verify well-formedness after action, e.g.
      • Model dead?
      • 1 member left in Alt-Group -> Mandatory
      • 1 member left if Or-Group -> Mandatory
      • Undo / Redo works?

SunVal added a commit that referenced this issue Nov 15, 2023
@h3ssto h3ssto mentioned this issue Nov 28, 2023
16 tasks
@tomatenhans tomatenhans removed their assignment Feb 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants