Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 500 error page failover #2

Open
NuroDev opened this issue Aug 1, 2024 · 1 comment
Open

Fix 500 error page failover #2

NuroDev opened this issue Aug 1, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@NuroDev
Copy link
Owner

NuroDev commented Aug 1, 2024

Similar to the issue mentioned in #1, currently if you include a 500.astro page in your project this adapter does not return that page if the SSR page fails to render.

I imagine some tweaks need to just be made to this line to wrap it in a try/catch to make it return the 500.html page if app.render() fails.

@NuroDev NuroDev added the bug Something isn't working label Aug 1, 2024
@NuroDev NuroDev self-assigned this Aug 1, 2024
@lilnasy
Copy link

lilnasy commented Dec 20, 2024

It seems to be working just fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants