Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New xpect version changed API, introduced compilation error in IDE #309

Closed
yoosiba opened this issue Nov 17, 2016 · 5 comments
Closed

New xpect version changed API, introduced compilation error in IDE #309

yoosiba opened this issue Nov 17, 2016 · 5 comments

Comments

@yoosiba
Copy link
Contributor

yoosiba commented Nov 17, 2016

My current Oomph based ide installation uses org.xpect.ui bundle in version 0.1.0.201609091551.

Performing new Oomph install pulls version 0.2.0.201611170958. That causes compilation problems of the IDE.

--edit
see eclipse/Xpect#203

@torstenkraemer
Copy link
Contributor

Strategy here would be

  • pinpoint org.xpect.ui in one Manifest at least to < 0.2.0 version
  • or -
  • solve the compilation problem and submit patch to master

@yoosiba
Copy link
Contributor Author

yoosiba commented Nov 18, 2016

Code wise patch is simple, literally two liner, but I don't know if there won't be issues at runtime. I will run builds with the patch.

@meysholdt are there any changes to the behaviour that are risky ?

@yoosiba yoosiba self-assigned this Nov 18, 2016
@meysholdt
Copy link
Contributor

meysholdt commented Nov 18, 2016

@yoosiba thanks for trying the new version! I'll comment on your code changes :)

@torstenkraemer
Copy link
Contributor

Just created a ticket, that describes the underlying cause eclipse/Xpect#203

numberfour-hudson pushed a commit that referenced this issue Nov 18, 2016
GH-309-a xpect update problem 0.1.0-0.2.0
numberfour-hudson pushed a commit that referenced this issue Nov 23, 2016
@JensN4 JensN4 modified the milestone: Sprint 56 Nov 30, 2016
@JensN4 JensN4 modified the milestones: Sprint 56, Sprint 57 Dec 21, 2016
@mmews-n4 mmews-n4 added ready and removed ready labels Dec 22, 2016
@mmews-n4 mmews-n4 modified the milestones: Sprint 57, Sprint 58 Jan 18, 2017
@yoosiba
Copy link
Contributor Author

yoosiba commented Jan 24, 2017

With changes in Xpect and in N4JS (recent update of target platform) this issue is gone.
Closing.
Thx @meysholdt and @torstenkraemer for changes in last weeks.

@yoosiba yoosiba closed this as completed Jan 24, 2017
@JensN4 JensN4 removed the ready label Jan 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants