Add CPM scenario for NU1604 #3320
Conversation
|
Learn Build status updates of commit 2c6d7c8: 💡 Validation status: suggestions
docs/reference/errors-and-warnings/NU1604.md
For more details, please refer to the build report. Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them. For any questions, please:
|
| which implies a lower bound. | ||
|
|
||
| > [!Note] | ||
| > When using CPM and the file `Directory.Packages.Props` is invalid, NU1604 is raised. |
There was a problem hiding this comment.
I added this because the original issue is related to an invalid file but makes me think this is a bug instead of a docs issue. @jeffkl what do you think?
| @@ -32,3 +32,22 @@ or | |||
| > `<PackageReference Version="9.0.0" />` | |||
|
|
|||
| which implies a lower bound. | |||
|
|
|||
| If using [Central Package Managment](https://learn.microsoft.com/nuget/consume-packages/Central-Package-Management) you will need to update the `PackageVersion` `Version` attribute in your `Directory.Packages.Props` file. | |||
There was a problem hiding this comment.
Normally this would be a different scenario.
We'd have another Issue, Solution etc.
We should also call out that this is a special case, since in a properly onboarded CPM scenario, you'd get NU1008.
There was a problem hiding this comment.
I wasn't sure if I should put it in another Solution section since it's the same error but yeah it's a special case so I can start with that
There was a problem hiding this comment.
Here's prior art from both restore and pack.
There was a problem hiding this comment.
When CPM is enabled, is the warning/error message the same, or different?
If the warning/error message is different when CPM is enabled compared to when it's not, it's important to have a sample of the message in these docs so that if the customer searches those words, they're more likely to find these docs.
| @@ -32,3 +32,22 @@ or | |||
| > `<PackageReference Version="9.0.0" />` | |||
|
|
|||
| which implies a lower bound. | |||
|
|
|||
| If using [Central Package Managment](https://learn.microsoft.com/nuget/consume-packages/Central-Package-Management) you will need to update the `PackageVersion` `Version` attribute in your `Directory.Packages.Props` file. | |||
There was a problem hiding this comment.
nit: my readability preference would be for something between these two words..
| If using [Central Package Managment](https://learn.microsoft.com/nuget/consume-packages/Central-Package-Management) you will need to update the `PackageVersion` `Version` attribute in your `Directory.Packages.Props` file. | |
| If using [Central Package Managment](https://learn.microsoft.com/nuget/consume-packages/Central-Package-Management) you will need to update the `PackageVersion` element's `Version` attribute in your `Directory.Packages.Props` file. |
|
|
||
| > `<PackageVersion Include="PackageA" Version="(9.0.0, )" />` | ||
|
|
||
|
|
| @@ -32,3 +32,22 @@ or | |||
| > `<PackageReference Version="9.0.0" />` | |||
|
|
|||
| which implies a lower bound. | |||
|
|
|||
| If using [Central Package Managment](https://learn.microsoft.com/nuget/consume-packages/Central-Package-Management) you will need to update the `PackageVersion` `Version` attribute in your `Directory.Packages.Props` file. | |||
| For example change from: | |||
There was a problem hiding this comment.
| For example change from: | |
| For example, change from: |
| @@ -32,3 +32,22 @@ or | |||
| > `<PackageReference Version="9.0.0" />` | |||
|
|
|||
| which implies a lower bound. | |||
|
|
|||
| If using [Central Package Managment](https://learn.microsoft.com/nuget/consume-packages/Central-Package-Management) you will need to update the `PackageVersion` `Version` attribute in your `Directory.Packages.Props` file. | |||
There was a problem hiding this comment.
| If using [Central Package Managment](https://learn.microsoft.com/nuget/consume-packages/Central-Package-Management) you will need to update the `PackageVersion` `Version` attribute in your `Directory.Packages.Props` file. | |
| If using [Central Package Managment](https://learn.microsoft.com/nuget/consume-packages/Central-Package-Management), you will need to update the `PackageVersion` `Version` attribute in your `Directory.Packages.Props` file. |
|
Closing in favor of #3350 which I'll incorporate these changes into |
Fix: NuGet/Home#13500
Added the scenario for users using CPM and NU1604 is raised.