-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support CMake C++ Projects (with Visual Studio Solution/Project) #12465
Comments
In #12204 (comment), the customer says |
I'm a different person than that commenter with a different pitch, the comment you have cited does not reflect my views nor the concern which I have wished to raise with the Nuget team. I have raised issue with the Nuget team and do specifically care about Nuget (and not "whatever the current package console is using") for the reason I hope is clear from my pitch. I gave a very specific use case which I came accross but which I think makes a good case for why change is required. On MicrosoftEdge/WebView2Samples#174 I have suggested that if the Microsoft Edge WebView2 samples showed a different system other than Nuget than that would be an alternative way to address the specific issue that led to me creating this issue ticket with the Nuget team; but I see it as separate from what I have I have requested here: on that ticket with the Edge team I feel it is appropriate to suggest that solution to the need for a sample might be realised using an alternative other than Nuget at Microsoft's descretion, for aquiring the resources needed to build native solutions with WebView2; here I have raised that the Nuget team should work with CMake for C/C++ native code projects, and referenced that use case as a reason it requires futher consideration. I believe that as Microsoft is currently using Nuget as seemingly the only way to get the required binaries and headers build against Webview2 with native code, it is not appropriate to dismiss the use case of making Nuget work with CMake for native projects, and that the Nuget team should create some mechanism (that need not be the CLI requested in 12204) to in order to facilitate this. |
To quote the CMake ticket for 24103 " VS_PACKAGE_REFERENCES does not work for native (C/C++) Nuget packages that use packages.config", a CMake developer laments:
It is in response to this that gh-andre says that they logged the 12204 request here (extract):
|
Any update on this issue? |
Any update on this issue? |
NuGet Product(s) Involved
NuGet.exe
The Elevator Pitch
#12204 proposed changes to the Nuget CLI and was rejected. It looks like it was raised per issue https://gitlab.kitware.com/cmake/cmake/-/issues/24103 with CMake, where VS_PACKAGE_REFERENCES can not be made to work with native packages & C/C++.
Until today I didn't expect to have an easy time with CMake, Nuget and native C/C++ code, I just expect nuget to treat me right when I work within the .net ecosystem; however Microsoft tells me to use Nuget to use the Edge WebView2, even with native WIN32 C++ code https://learn.microsoft.com/en-us/microsoft-edge/webview2/get-started/win32
I don't care about the Nuget CLI change specifically requested in #12204 but if Microsoft is endorsing Nuget as the way to get the libraries and headers needed to build against WebView2, I think it's reasonable to expect it (Nuget) to work with CMake, as CMake is otherwise encouraged / supported.
Additional Context and Details
See also open tickets #6731, #8874 and maybe #10144 I believe these were all raised before the CMake team added some support via the CMake VS_PACKAGE_REFERENCES property. Per the gitlab ticket referenced the CMake team appears to need some mechanism to make this work from the Microsoft / Nuget side of things, if not the change to the Nuget CLI suggested by gh-andre than I kindly ask the Nuget team proposes and implements an alternative for CMake support.
The text was updated successfully, but these errors were encountered: