Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Category comparator is not scalable #2

Open
sp0rk opened this issue Mar 12, 2017 · 1 comment
Open

Category comparator is not scalable #2

sp0rk opened this issue Mar 12, 2017 · 1 comment

Comments

@sp0rk
Copy link

sp0rk commented Mar 12, 2017

Imagine having to add several other Categories to your code. The compareTo() method would be painful to expand. Consider storing the constants in an ordered collection, like a list for example.

@wzieba
Copy link
Member

wzieba commented Mar 12, 2017

Yes, this is also correct. I will figure out something better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants