fix: Be really specific and culture agnostic about how we serialise dates for soap messages.

Author: Henrik Otte Sørensen

src/STIL.ServiceClient/DTOs/SPSA/GetOrdrer/GetOrdrerQuery.cs

@@ -1,6 +1,8 @@
 using System;
 using System.Diagnostics;
+using System.Globalization;
 using System.Xml.Serialization;
+using STIL.ServiceClient.Util.SoapHelper;
 
 namespace STIL.ServiceClient.DTOs.SPSA.GetOrdrer;
 
@@ -15,13 +17,13 @@ public GetOrdrerQuery()
 
     public GetOrdrerQuery(DateTime? from = null, DateTime? to = null)
     {
-        fromTime = from?.ToUniversalTime().ToString("yyyy-MM-dd'T'HH:mm:ss.fff'Z'");
-        toTime = to?.ToUniversalTime().ToString("yyyy-MM-dd'T'HH:mm:ss.fff'Z'");
+        fromTime = from?.ToSoapString();
+        toTime = to?.ToSoapString();
     }
 
     [XmlElement(IsNullable = true, Order = 0)]
-    public string fromTime { get; set; }
+    public string? fromTime { get; set; }
 
     [XmlElement(IsNullable = true, Order = 1)]
-    public string toTime { get; set; }
+    public string? toTime { get; set; }
 }

src/STIL.ServiceClient/STIL.ServiceClient.csproj

@@ -11,7 +11,7 @@
 
 
 	<PropertyGroup Label="Nuget information">
-		<Version>1.1.0</Version>
+		<Version>1.1.1</Version>
 		<Authors>PensionDanmark</Authors>
 		<Owners>PensionDanmark</Owners>
 		<Copyright>Copyright © PensionDanmark 2023</Copyright>

src/STIL.ServiceClient/Util/SoapHelper/SoapBuilder.cs

@@ -131,8 +131,8 @@ private Guid AddBinarySecurityToken(XDocument document, X509Certificate2 signing
         private void AddTimeStamp(XDocument document)
         {
             XElement secElement = document.Descendants(securityWSNs + "Security").Single();
-            string created = $"{DateTime.UtcNow:O}".Substring(0, 23) + "Z";
-            string expires = $"{DateTime.UtcNow.AddMinutes(5):O}".Substring(0, 23) + "Z";
+            string created = DateTime.UtcNow.ToSoapString();
+            string expires = DateTime.UtcNow.AddMinutes(5).ToSoapString();
             secElement.Add(new XElement(
                 securityUtilNs + "Timestamp",
                 new XAttribute(securityUtilNs + "Id", $"TimestampRef"),

src/STIL.ServiceClient/Util/SoapHelper/SoapDateTimeFormatter.cs

@@ -0,0 +1,22 @@
+using System;
+using System.Globalization;
+
+namespace STIL.ServiceClient.Util.SoapHelper;
+
+/// <summary>
+/// Extension method to format DateTimes so that STIL's IPL Soap server will accept them.
+/// </summary>
+public static class SoapDateTimeFormatter
+{
+    private const string _formatString = @"yyyy'-'MM'-'dd'T'HH':'mm':'ss'.'fff'Z'";
+
+    /// <summary>
+    /// Formats DateTime as a ISO-8601 UTC string.
+    /// </summary>
+    /// <param name="dateTime">DateTime.</param>
+    /// <returns>Soap friendly formatted DateTime string.</returns>
+    public static string ToSoapString(this DateTime dateTime)
+    {
+        return dateTime.ToUniversalTime().ToString(_formatString, CultureInfo.InvariantCulture);
+    }
+}