Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JUnit Tests and CI #4

Open
kevinthegreat1 opened this issue May 2, 2024 · 2 comments
Open

Add JUnit Tests and CI #4

kevinthegreat1 opened this issue May 2, 2024 · 2 comments

Comments

@kevinthegreat1
Copy link
Contributor

This repo seems to lack automatic tests and CI.

It has the kotest library but doesn't seem to use it? Would the maintainers be open to a pr that replaces kotest with JUnit and adds CI?

Great library btw, thanks for your work!

@nea89o
Copy link
Member

nea89o commented May 2, 2024

Hey!

Thanks for your interest. I originally intended for CI to be ran on this, but I found it difficult to decide on a way to use the repo. Ideally I would test against the entire repo, and that is an ever evolving piece of data that changes all the time. Finding a balance between just copying individual JSON files into this repo to test just those and running against the entire repo and potentially breaking when there is an update is something I have not yet solved.

Either one of those approaches would be appreciated tho.

@kevinthegreat1
Copy link
Contributor Author

Hi,

Thanks for your reply. I can run against the entire repo with GitHub Actions. I'll submit a pr with that and JUnit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants