Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sqls is deprecated, use sqlls instead #126

Open
1 task done
MonaMayrhofer opened this issue Aug 10, 2023 · 4 comments
Open
1 task done

sqls is deprecated, use sqlls instead #126

MonaMayrhofer opened this issue Aug 10, 2023 · 4 comments
Labels
bug Something isn't working

Comments

@MonaMayrhofer
Copy link

⚠️ Please verify that this bug has NOT been reported before.

  • I checked all existing issues and didn't find a similar issue

Description

Hi its me again :P

It seems like the sql language server sqls is public archive.
nvim-lspconfig have decided to deprecate it and will remove it in version 0.2.0 (See here)

They suggest replacing it with sqlls, which is already available in nvim-lspconfig (See here)
It can be downloaded on npm, however there is no dedicated nixos package yet, so that would have to be done in a derivation using node2nix or similar means... which probably bloats this flake quite a bit.

I don't know what the best way to proceed here is, but i thought it probably should be an issue, just for completeness sake...

👟 Reproduction steps

{
  inputs = {
    nixpkgs.url = "nixpkgs/nixos-23.05";
    neovim-flake = {
      url = "github:notashelf/neovim-flake";
      inputs.nixpkgs.follows = "nixpkgs";
    };
  };

  outputs = {
    nixpkgs,
    neovim-flake,
    ...
  }: let
    configModule = {
      config = {
        vim.languages = {
          enableLSP = true;
          sql.enable = true;
        };
      };
    };
    pkgs = import nixpkgs {
      system = "x86_64-linux";
    };
    customNeovim = neovim-flake.lib.neovimConfiguration {
      modules = [configModule];
      inherit pkgs;
    };
  in {
    packages.x86_64-linux.default = customNeovim.neovim;
  };
}

👀 Expected behavior

Starts up fine

😓 Actual Behavior

When starting vim, you are prompted with a deprecation warning before you enter the editor.

💻 Metadata

  • system: "x86_64-linux" - host os: Linux 6.1.44, NixOS, 23.05 (Stoat), 23.05.20230809.9034b46 - multi-user?: yes - sandbox: yes - version: nix-env (Nix) 2.13.5 - channels(root): "home-manager-22.11.tar.gz, nixos-23.05" - nixpkgs: /nix/var/nix/profiles/per-user/root/channels/nixos

📝 Relevant log output

sqls is deprecated, use sqlls instead.
This feature will be removed in lspconfig version 0.2.0
Press ENTER or type command to continue
@MonaMayrhofer MonaMayrhofer added the bug Something isn't working label Aug 10, 2023
@NotAShelf
Copy link
Owner

NotAShelf commented Aug 10, 2023

I'm very well aware of this issue, and have been meaning to resolve it for a while now. Unfortunately my last attempt has resulted in a failure thanks to, well, the best (worst) efforts of the nodejs ecosystem.

We are (currently) blocked by NixOS/nixpkgs#203887 - I intend to take another shot at packaging it soon.

@MonaMayrhofer
Copy link
Author

Super cool, thanks!!

@NotAShelf
Copy link
Owner

I'm afraid I can't get sqlls to work as a nixpkgs package. I'll take another look when I have more time.

@NotAShelf
Copy link
Owner

Revisiting, the package still does not compile due to the default package.json having some fields that nixpkgs cannot conform to - will try with a patched package.json and get it in either nixpkgs or our own packages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants