Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can I delete 'DfuBaseService'? #482

Open
sieunju opened this issue Dec 17, 2024 · 3 comments
Open

Can I delete 'DfuBaseService'? #482

sieunju opened this issue Dec 17, 2024 · 3 comments
Labels

Comments

@sieunju
Copy link

sieunju commented Dec 17, 2024

Target

Library

Describe the feature

Why?

  • The advantage of using the 'DfuBaseService' inherited service is that you can safely upload DFU.
    However, if you upload several DFUs at the same time, you have to add several of the relevant 'DfuBase Service' and declare it in 'Android Manifest'.

Solution

  • How about controlling DFU uploads to be processed within one class?
@sieunju sieunju changed the title [Core] Can I delete 'DfuBaseService'? Can I delete 'DfuBaseService'? Dec 17, 2024
@philips77
Copy link
Member

Yes, true. This is a very old library, modern approach would be very different, with split for transport and logic, tests, etc.
IntentService besides that is deprecated and it's the user that should decide how and where to run it, e.g. in WorkManager.

Anyway, you may cut the relevant part from the DfuBaseService and implement it as a method.

We have a (very) long plan to finish Version 2 of Kotlin BLE Library and rewrite DFU using it.

@sieunju
Copy link
Author

sieunju commented Dec 18, 2024

Aha, does the Version 2 of Kotlin BLE Library have a Device Firmware Update (DFU) feature?? 🙇‍♂️

@philips77

@philips77
Copy link
Member

No, it's lower layer. Handles GATT and GAP operations (connection, GATT, advertising) and allows peripheral emulation for test, kinds like CoreBluetooth Mock for iOS, but better. And it may be KMM at some point also.

The new DFU would be built on top of it as version 3 of DFU library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants