Prepare tools for icenet #60
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgruening
reviewed
Apr 5, 2023
tools/preprocess/preprocess.xml
Outdated
| echo "regridding is done" && | ||
| mkdir "data/network_datasets" && | ||
| mkdir "data/network_datasets/dataset1" && | ||
| mv $norm_file "data/network_datasets/norm_params.json" && |
There was a problem hiding this comment.
norm_file should be single-quoted
tools/preprocess/preprocess.xml
Outdated
| echo "preprocessing is done" | ||
| ]]></command> | ||
| <inputs> | ||
| <param name="config_file" type="data" label="config file" format="json"/> |
There was a problem hiding this comment.
The labels should be enhanced. A user potentially do not know how such a config file looks like or where to obtain it.
tools/preprocess/preprocess.xml
Outdated
| <param name="vas_file" type="data" label="vas netcdf file" format="netcdf"/> | ||
| </inputs> | ||
| <outputs> | ||
| <collection name="collection1" type="list"> |
There was a problem hiding this comment.
better name than just collection
tools/preprocess/preprocess.xml
Outdated
| </tests> | ||
| <help><![CDATA[ | ||
|
|
||
| This tool is a wrapper to preprocess icenet data (netcdf files). |
tools/preprocess/preprocess.xml
Outdated
| This tool is a wrapper to preprocess icenet data (netcdf files). | ||
| ]]></help> | ||
| <citations> | ||
| <citation type="bibtex"> |
There was a problem hiding this comment.
here you can use the type="doi"
tools/preprocess/preprocess.xml
Outdated
Comment on lines
210
to
219
| <citation type="bibtex"> | ||
| @misc{https://doi.org/10.5281/zenodo.5176573, | ||
| doi = {10.5281/ZENODO.5176573}, | ||
| url = {https://zenodo.org/record/5176573}, | ||
| author = {Andersson, Tom R.}, | ||
| title = {Code associated with the paper: 'Seasonal Arctic sea ice forecasting with probabilistic deep learning'}, | ||
| publisher = {Zenodo}, | ||
| year = {2021}, | ||
| copyright = {Open Access} | ||
| } |
There was a problem hiding this comment.
Suggested change
| <citation type="bibtex"> | |
| @misc{https://doi.org/10.5281/zenodo.5176573, | |
| doi = {10.5281/ZENODO.5176573}, | |
| url = {https://zenodo.org/record/5176573}, | |
| author = {Andersson, Tom R.}, | |
| title = {Code associated with the paper: 'Seasonal Arctic sea ice forecasting with probabilistic deep learning'}, | |
| publisher = {Zenodo}, | |
| year = {2021}, | |
| copyright = {Open Access} | |
| } | |
| <citation type="doi">10.5281/zenodo.5176573 |
tools/preprocess/preprocess.xml
Outdated
| @@ -0,0 +1,222 @@ | |||
| <tool id="preprocess" name="Preprocess Icenet Data" version="0.1.0+galaxy0" python_template_version="3.5" profile="21.05"> | |||
There was a problem hiding this comment.
Suggested change
| <tool id="preprocess" name="Preprocess Icenet Data" version="0.1.0+galaxy0" python_template_version="3.5" profile="21.05"> | |
| <tool id="preprocess" name="Preprocess Icenet Data" version="0.1.0+galaxy0" profile="21.05"> |
paulzierep
reviewed
Apr 19, 2023
| @@ -16,43 +16,46 @@ | |||
| </requirements> | |||
| <command detect_errors="exit_code"><
There was a problem hiding this comment.
if $test_tool:
prepare_era5_data.py -h
repare_era5_data.py -h
else:
There was a problem hiding this comment.
<param name="test_data_manager" type="hidden" value=""/>
<test expect_num_outputs="1">
<param name="test_data_manager" value="--test"/>
bgruening
reviewed
Sep 26, 2023
| @@ -57,43 +57,43 @@ | |||
| <outputs> | |||
| <data name="siconca_EASE_file" format="netcdf" from_work_dir="data/obs/siconca_EASE.nc"/> | |||
| <collection name="siconca_dataset" type="list"> | |||
| <discover_datasets pattern="__name_and_ext__" directory="data/network_datasets/dataset1/obs/siconca/abs"/> | |||
| <discover_datasets pattern="__name__" format="binary" directory="data/network_datasets/dataset1/obs/siconca/abs"/> | |||
There was a problem hiding this comment.
Why binary? What is this in real? Can we not output here a real standard fileformat?
|
@annefou do you want to take a look here? |
Yes we need to finalise this tool. I can work on it next week (19-24 November 2023) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.