Merge pull request #358 from fzakaria/faridzakaria/off-by-one

Mic92 · web-flow · commit b73dbc1c91fc · 2021-12-19T12:28:38.000Z
print-interpreter: fix off by one error
diff --git a/.gitignore b/.gitignore
@@ -32,3 +32,7 @@ Makefile
 /tests/libbig-dynstr.debug
 /tests/contiguous-note-sections
 /tests/simple-pie
+
+.direnv/
+.vscode/
+.idea/
diff --git a/src/patchelf.cc b/src/patchelf.cc
@@ -1237,7 +1237,7 @@ template<ElfFileParams>
 std::string ElfFile<ElfFileParamNames>::getInterpreter()
 {
     auto shdr = findSection(".interp");
-    return std::string((char *) fileContents->data() + rdi(shdr.sh_offset), rdi(shdr.sh_size));
+    return std::string((char *) fileContents->data() + rdi(shdr.sh_offset), rdi(shdr.sh_size) - 1);
 }
 
 template<ElfFileParams>

Original file line number	Diff line number	Diff line change
`@@ -1237,7 +1237,7 @@ template<ElfFileParams>`
`1237`	`1237`	`std::string ElfFile<ElfFileParamNames>::getInterpreter()`
`1238`	`1238`	`{`
`1239`	`1239`	`auto shdr = findSection(".interp");`
`1240`		`- return std::string((char *) fileContents->data() + rdi(shdr.sh_offset), rdi(shdr.sh_size));`
	`1240`	`+ return std::string((char *) fileContents->data() + rdi(shdr.sh_offset), rdi(shdr.sh_size) - 1);`
`1241`	`1241`	`}`
`1242`	`1242`
`1243`	`1243`	`template<ElfFileParams>`