Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit tests to platforms supported by a package by default #348182

Open
felixsinger opened this issue Oct 13, 2024 · 0 comments
Open

Limit tests to platforms supported by a package by default #348182

felixsinger opened this issue Oct 13, 2024 · 0 comments

Comments

@felixsinger
Copy link
Member

felixsinger commented Oct 13, 2024

Issue description

I've noticed in various situations that the CI tries to execute tests on platforms which are not supported by the package. That leads to unnecessary evaluation attempts and ultimately errors in the CI summary of a pull requests. One of my recent examples is Redmine.

However, I've just learned that tests may be limited to specific platforms with handleTestOn in nixos/tests/all-tests.nix. By using that, it seems, the CI won't even try to run the tests on an unsupported platform and the unsupported platform is just marked as successful in the summary.

Now, I'm wondering why handleTest doesn't use the platforms supported by a package as default. For example, without the limitation I've done in #348178 the CI will try to test Redmine on Darwin platforms even if they are not supported by the Redmine package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant