-
-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reformat Nixpkgs #322520
Comments
15 tasks
This issue has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/formatting-team-meeting-2024-05-28/46126/1 |
13 tasks
13 tasks
This was referenced Jun 19, 2024
First step towards this, |
This was referenced Jun 26, 2024
After the above PR, here's the next one with first formatting pass! #322537 🎉 |
2 tasks
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The recent python reformatting has shown that people are eager to have a uniform style already. Even though nixfmt isn't fully stable yet, we can already go ahead and use it to reformat all of Nixpkgs. With future nixfmt changes it can be reformatted again.
shell.nix
/direnv integration: Development shell with a pinned nixfmt #322512Make sure
--verify
succeeds: Use --verify in Nixpkgs diff CI nixfmt#215Change the workflow to only enforce formatting of new/changed files, and do the first formatting pass
Fix [Tracking issue] remove all
src = ./.
entries that unintentionally include their own.nix
files #301014Wait until after the current release, minimise the number of conflicts (by picking a time with minimal open PRs)
[ ] Have better integrationMaketreefmt
,nix fmt
workFix Remove recursive mode nixfmt#151 beforehand[ ] Have an easy maintainer script to rebase PRs with formatting: Script to rebase with formatting nixfmt#159Not a blocker
Open an issue/discourse post with information on the nixfmt reformatting
Format all actively developed branches (master, release-, staging-? (ask staging maintainers)) at the same time to avoid all backporting problems
[ ] Figure out how to do future reformats and nixfmt updates (pin it, probably separately from the main package)Not a blocker
[ ] Make sure there's no problems with generated filesCI will complain when they get updated without being formatted, which gives a good signal to the PR author that they need to either manually format, or implement the formatting in the generator
The text was updated successfully, but these errors were encountered: