Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Old version of cppcodec #494

Open
panicgh opened this issue Mar 25, 2023 · 1 comment
Open

Old version of cppcodec #494

panicgh opened this issue Mar 25, 2023 · 1 comment
Labels
enhancement maintenance
Milestone
1.5

Comments

@panicgh
Copy link
Contributor

panicgh commented Mar 25, 2023

nitrokey-app uses a very old version of cppcodec (unreleased/-tagged, a commit from 2016) via a git submodule.

It may be worthwhile to update the git submodule to a later version. For example, I tried the latest tagged version v0.2 (2018) and so far it seems to work just fine. The latest commits are from 2022.
@panicgh panicgh mentioned this issue Mar 26, 2023
Merged
12 tasks
@szszszsz szszszsz added this to the 1.5 milestone Mar 27, 2023
@szszszsz
Copy link
Member

Hi!
Thank you for checking that out. For our very small use case it was good enough at the time (hex-base32 conversion). Perhaps worth updating in case there were any security updates, otherwise let's use what is proved to be working stably.
Leaving open in case there would be another release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement maintenance
Projects
None yet
Milestone
1.5
Development

No branches or pull requests
2 participants
@szszszsz @panicgh