Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

40 UI nitropad does not reboot as state in the UI message after oem factory resetfirmware upgrade #43

Open
wants to merge 2 commits into
base: nitropad
Choose a base branch
from

Conversation

alexgithublab
Copy link
Collaborator

This is for #40

changed the comment and changed the ui message to be more clear
@tlaurion
Copy link

tlaurion commented Apr 4, 2024

@nestire how is this normal?

@tlaurion
Copy link

tlaurion commented Apr 4, 2024

There are two scripts. Shutdown and reboot.
Seems like what is passed to EC in reboot is buggy.

Since the goal is to fix things and not add more workaround, is there bug reports upstream so that ec/coreboot port is fixed?

@alexgithublab
Copy link
Collaborator Author

If we remove the "if" from this commit the rebooting script is working.

not sure why @daringer did this

@daringer
Copy link
Collaborator

this essentially was a safety measure as I can not reliably say, which portions of the flash have to be overwritten to fail during the next power cycle so the safety measure was to always shutdown via the EC. During testing I often flash from within HEADS using flashrom directly and overwriting the entire flash, then EC shutdown is needed ... using the UI this seems not necessary as only the bios region is written.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI Nitropad does not reboot as state in the UI Message after OEM Factory reset/Firmware Upgrade
3 participants