Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modifying reprojection error #4

Open
ShtainZ opened this issue Dec 8, 2021 · 1 comment
Open

Modifying reprojection error #4

ShtainZ opened this issue Dec 8, 2021 · 1 comment

Comments

@ShtainZ
Copy link

ShtainZ commented Dec 8, 2021

Hello,
I would like to use your Bundle Adjustment solution with a different projection error based on another research in my field of study.
The parameters of the camera pose do not change, only the projection mapping. Is there a way to add this kind of modification?
Regards,
Zachi

@NikolausDemmel
Copy link
Owner

NikolausDemmel commented Dec 8, 2021

Hi, thanks for your interest.

Depends a bit on what exactly the error formulation you had in mind looks like. If the parameterization stays the same, as you mentioned, and if also the "connectivity" is the same (every residual connects one camera and one landmark), then it should be doable with quite minimal changes.

For the custom solvers, your main entry would be to modify compute_error and linearize_point in https://github.com/NikolausDemmel/rootba/blob/master/src/rootba/bal/bal_bundle_adjustment_helper.cpp, and for the ceres solvers you'd go and adjust https://github.com/NikolausDemmel/rootba/blob/master/src/rootba/ceres/bal_residuals.hpp

Edit: compute_error can probably stay the same, since it just calls linearize_point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants