Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iOS - isAvailable function generalize the error code, however authenticate function have proper error code mapping #226

Open
jainank opened this issue Feb 11, 2020 · 3 comments · May be fixed by #227
Open

iOS - isAvailable function generalize the error code, however authenticate function have proper error code mapping #226

jainank opened this issue Feb 11, 2020 · 3 comments · May be fixed by #227
Assignees
@jainank
Labels
bug help wanted ios

Comments

@jainank
Copy link

jainank commented Feb 11, 2020 •
edited
Loading

Bug report

Description

For iOS application, I am calling isAvailable function when touchID is locked because of multiple invalid attempts.
My expectation was that the application will return error code:
case BIOMETRIC_LOCKED_OUT = -111

However it retuned:
case BIOMETRIC_UNKNOWN_ERROR = -100

Environment

  • Plugin version
    2.2.2

Platform:
iOS
@jainank jainank added the bug label Feb 11, 2020
@NiklasMerz
Copy link
Owner

Looks like this error should be supported:

cordova-plugin-fingerprint-aio/src/ios/Fingerprint.swift

Line 15 in 8a66c24

case BIOMETRIC_LOCKED_OUT = -111

I guess we need to detect it here:

cordova-plugin-fingerprint-aio/src/ios/Fingerprint.swift

Line 59 in 8a66c24

switch(error!._code) {

The error should be thrown correctly while using the show function?

Adding @greaterking because he is more familiar with this new iOS code.

@jainank
Copy link
Author

jainank commented Feb 12, 2020

I forked the repo, and fixed it in my local.
Let me know if you want me to create PR. Happy to help!

@NiklasMerz
Copy link
Owner

Awesome. Of course create the PR and we will review it. Looking forward.

@NiklasMerz NiklasMerz assigned jainank and unassigned greaterking Feb 12, 2020
@jainank jainank linked a pull request Feb 12, 2020 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jainank jainank

Labels
bug help wanted ios
Projects
None yet
Milestone
No milestone
3 participants
@jainank @greaterking @NiklasMerz