Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Load/Save Settings from the 3-dot menu #3071

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Navid200
Copy link
Collaborator

@Navid200 Navid200 commented Sep 6, 2023

To save or load settings, it makes sense to do it by first going to settings.
If you do that, you will see a section titled "Copying settings".
Under it, you can copy or load settings using either the QR code or creating/loading the file.

What currently exists under the 3-dot menu is redundant.
Can we please remove it to help clean up?

This is what it will look like after this PR:
Screenshot_20230906-175335

This has been tested.

@jamorham
Copy link
Collaborator

jamorham commented Sep 8, 2023

This menu deals with import export of data from xDrip of which settings are an important part. I don't really see why to remove the feature from a deep menu.

@Navid200
Copy link
Collaborator Author

Navid200 commented Sep 8, 2023

There are too many settings in xDrip.
It is so bad that when we do no need a new setting, I try to modify my PR not to add a new setting. Because there are so many settings making it hard for a newcomer to find out what is what.

So, when I see the same setting available in more than one place, I cannot help wondering why.
If one needs to save or load settings, they can do it by going to settings. To me, that is the intuitive thing anyone would do.
So, comparing the two, I suggest, we keep the one in settings and remove this one to clean up.
We have a long way to go in this front. This is a small step.
Who is going to complain? I mean how hard is it to tap on settings to copy the settings?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants