Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Retry-After header GCM #22

Open
SimonV opened this issue Jan 23, 2014 · 2 comments
Open

Support for Retry-After header GCM #22

SimonV opened this issue Jan 23, 2014 · 2 comments

Comments

@SimonV
Copy link

SimonV commented Jan 23, 2014

GCM documentation says that 5xx range responses can contain Retry-After response header with time to wait before next request.

Is it possible to add some sort of indication that this header was returned and pass the Retry-After value to the caller of the gem?

The relevant documentation : http://developer.android.com/google/gcm/http.html

@NicosKaralis
Copy link
Owner

Possible to implement it is, but we would need extra libs and gems

Do we really want some "auto retry-er"? this would involve some delayed jobs that i don't see relevant and would possibly make dependencies that is pretty much project specific, like delayed_job or resque? if i have already resque why the gem is using delayed_job.

I could think in some extension gem, like 'pushmeup_resque' or something but in this gem i would rather leave without this functionality.

tl;dr : is it really important for you? do you think a separate gem to handle that would be too bad? you tell me and i see what i will do

@SimonV
Copy link
Author

SimonV commented Mar 1, 2014

This is no longer important for me personaly.

What I had in mind was not an implementation of an auto retry mechanism, that would indeen be over complicated. I just wanted the Auto-Retry value returned by GCM on the header to be passed to the caller of the gem. Right now it's impossible to access from outside the gem and it's being ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants