Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Sim tests broken due to removal of x/vesting Cosmos-SDK module #2146

Closed
Unique-Divine opened this issue Jan 8, 2025 · 1 comment · Fixed by #2147
Closed

[bug] Sim tests broken due to removal of x/vesting Cosmos-SDK module #2146

Unique-Divine opened this issue Jan 8, 2025 · 1 comment · Fixed by #2147
Labels
S-triage Status: This issue is waiting on initial triage. More Info: https://tinyurl.com/25uty9w5

Comments

@Unique-Divine
Copy link
Member

Unique-Divine commented Jan 8, 2025

Reference: https://github.com/NibiruChain/nibiru/actions/runs/12664067711/job/35291630943

[View Test Log]
1
Run make test-sim-after-import
4
Running application simulation-after-import. This may take several minutes...
5
=== RUN   TestAppSimulationAfterImport
6
Starting SimulateFromSeed with randomness created with seed 99
7
Randomized simulation params: 
8
{}
9
2025/01/08 04:27:32 Selected randomly generated parameters for simulated genesis:
10
{
11
  stake_per_account: "13811750517",
12
  initially_bonded_validators: "81"
13
}
14
Selected randomly generated auth parameters:
15
{
16
 "max_memo_characters": 100,
17
 "tx_sig_limit": 9,
18
 "tx_size_cost_per_byte": 13,
19
 "sig_verify_cost_ed25519": 590,
20
 "sig_verify_cost_secp256k1": 568
21
}
22
--- FAIL: TestAppSimulationAfterImport (0.06s)
23
panic: unable to resolve type URL /cosmos.vesting.v1beta1.DelayedVestingAccount [recovered]
24
	panic: unable to resolve type URL /cosmos.vesting.v1beta1.DelayedVestingAccount
25

26
goroutine 14 [running]:
27
testing.tRunner.func1.2({0x2526840, 0xc000df59c0})
28
	/opt/hostedtoolcache/go/1.21.13/x64/src/testing/testing.go:1545 +0x238
29
testing.tRunner.func1()
30
	/opt/hostedtoolcache/go/1.21.13/x64/src/testing/testing.go:1548 +0x397
31
panic({0x2526840?, 0xc000df59c0?})
32
	/opt/hostedtoolcache/go/1.21.13/x64/src/runtime/panic.go:914 +0x21f
33
github.com/cosmos/cosmos-sdk/codec.(*ProtoCodec).MustMarshalJSON(0x3570ca0?, {0x3582b80?, 0xc0012a9900?})
34
	/home/runner/go/pkg/mod/github.com/!nibiru!chain/[email protected]/codec/proto_codec.go:156 +0x3c
35
github.com/cosmos/cosmos-sdk/x/auth/simulation.RandomizedGenState(0xc00133eea0, 0x304bf48)
36
	/home/runner/go/pkg/mod/github.com/!nibiru!chain/[email protected]/x/auth/simulation/genesis.go:133 +0x412
37
github.com/cosmos/cosmos-sdk/x/auth.AppModule.GenerateGenesisState(...)
38
	/home/runner/go/pkg/mod/github.com/!nibiru!chain/[email protected]/x/auth/module.go:173
39
github.com/cosmos/cosmos-sdk/types/module.(*SimulationManager).GenerateGenesisStates(...)
40
	/home/runner/go/pkg/mod/github.com/!nibiru!chain/[email protected]/types/module/simulation.go:128
41
github.com/NibiruChain/nibiru/v2/simapp_test.AppStateRandomizedFn(0xc000a64800, 0xc0012bba70, {0x35a6348?, 0xc000c16260}, {0xc0012c0000?, 0x1d1, 0x1d1}, {0x0, 0xfe7d6b0c4, 0x4dad680}, ...)
42
	/home/runner/work/nibiru/nibiru/simapp/state_test.go:186 +0x3f2
43
github.com/NibiruChain/nibiru/v2/simapp_test.TestAppSimulationAfterImport.AppStateFn.func4(0xc001290858?, {0xc0012c0000, 0x1d1, 0x1d1}, {{0x0, 0x0}, {0x7ffd9b2d4c6a, 0xb}, {0x0, 0x0}, ...})
44
	/home/runner/work/nibiru/nibiru/simapp/state_test.go:68 +0x1f3
45
github.com/cosmos/cosmos-sdk/x/simulation.initChain(0x35a1ca0?, {0x3fd0de74a4a10c77, _, _, {_, _, _}, {_, _}, {_, ...}}, ...)
46
	/home/runner/go/pkg/mod/github.com/!nibiru!chain/[email protected]/x/simulation/simulate.go:38 +0xd9
47
github.com/cosmos/cosmos-sdk/x/simulation.SimulateFromSeed({0x35c40c0?, 0xc0000ffd40?}, {_, _}, _, _, _, {0xc00125c900, 0x2d, 0x30}, ...)
48
	/home/runner/go/pkg/mod/github.com/!nibiru!chain/[email protected]/x/simulation/simulate.go:80 +0x4cf
49
github.com/NibiruChain/nibiru/v2/simapp_test.TestAppSimulationAfterImport(0xc0000ffd40)
50
	/home/runner/work/nibiru/nibiru/simapp/sim_test.go:324 +0x868
51
testing.tRunner(0xc0000ffd40, 0x304b088)
52
	/opt/hostedtoolcache/go/1.21.13/x64/src/testing/testing.go:1595 +0xff
53
created by testing.(*T).Run in goroutine 1
54
	/opt/hostedtoolcache/go/1.21.13/x64/src/testing/testing.go:1648 +0x3ad
55
FAIL	github.com/NibiruChain/nibiru/v2/simapp	0.179s
56
FAIL
57
make: *** [contrib/make/simulation.mk:47: test-sim-after-import] Error 1
58
Error: Process completed with exit code 2.

image

@github-project-automation github-project-automation bot moved this to ⚡ Building 🧱 in ⚛️ Nibiru (Hougyoku) Jan 8, 2025
@github-actions github-actions bot added the S-triage Status: This issue is waiting on initial triage. More Info: https://tinyurl.com/25uty9w5 label Jan 8, 2025
@github-project-automation github-project-automation bot moved this from ⚡ Building 🧱 to ✅ Completed in ⚛️ Nibiru (Hougyoku) Jan 8, 2025
@Unique-Divine
Copy link
Member Author

Unique-Divine commented Jan 8, 2025

The solution in #2147 should solve the problem. If it doesn't I'll reopen the ticket.

Edit: CI is passing with the new change

image

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-triage Status: This issue is waiting on initial triage. More Info: https://tinyurl.com/25uty9w5
Projects
Archived in project
1 participant