From dfc179893c5314460c3b5e04127758b307174fbd Mon Sep 17 00:00:00 2001
From: Unique-Divine <realuniquedivine@gmail.com>
Date: Thu, 28 Dec 2023 10:17:34 -0600
Subject: [PATCH] test(oracle): verify that params before are not equal

---
 x/oracle/keeper/sudo.go      |  6 +++---
 x/oracle/keeper/sudo_test.go | 24 +++++++++++++++---------
 2 files changed, 18 insertions(+), 12 deletions(-)

diff --git a/x/oracle/keeper/sudo.go b/x/oracle/keeper/sudo.go
index e5179ecfe..a73fcf490 100644
--- a/x/oracle/keeper/sudo.go
+++ b/x/oracle/keeper/sudo.go
@@ -38,15 +38,15 @@ func (k admin) EditOracleParams(
 		return fmt.Errorf("get oracle params error: %s", err.Error())
 	}
 
-	mergedParams := newParams.mergeOracleParams(params)
+	mergedParams := newParams.MergeOracleParams(params)
 	k.UpdateParams(ctx, mergedParams)
 	return nil
 }
 
-// mergeOracleParams: Takes the given oracle params and merges them into the
+// MergeOracleParams: Takes the given oracle params and merges them into the
 // existing partial params, keeping any existing values that are not set in the
 // partial.
-func (partial PartialOracleParams) mergeOracleParams(
+func (partial PartialOracleParams) MergeOracleParams(
 	oracleParams oracletypes.Params,
 ) oracletypes.Params {
 	if partial.PbMsg.VotePeriod != nil {
diff --git a/x/oracle/keeper/sudo_test.go b/x/oracle/keeper/sudo_test.go
index 8737d47dd..cfb8858bc 100644
--- a/x/oracle/keeper/sudo_test.go
+++ b/x/oracle/keeper/sudo_test.go
@@ -35,7 +35,7 @@ func (s *SuiteOracleSudo) TestEditOracleParams() {
 	twapLookbackWindow := sdk.NewInt(int64(time.Second * 30))
 	minVoters := sdk.NewInt(2)
 	validatorFeeRatio := sdk.MustNewDecFromStr("0.7")
-	partialParams := oracletypes.MsgEditOracleParams{
+	msgEditParams := oracletypes.MsgEditOracleParams{
 		VotePeriod:         &votePeriod,
 		VoteThreshold:      &voteThreshold,
 		RewardBand:         &rewardBand,
@@ -47,23 +47,29 @@ func (s *SuiteOracleSudo) TestEditOracleParams() {
 		MinVoters:          &minVoters,
 		ValidatorFeeRatio:  &validatorFeeRatio,
 	}
-	// TODO: Verify that params before were not equal
+
+	// Verify that params after are not equal
+	partialParams := oraclekeeper.PartialOracleParams{PbMsg: msgEditParams}
+	defaultParams := oracletypes.DefaultParams()
+	currParams, err := nibiru.OracleKeeper.Params.Get(ctx)
+	s.NoError(err)
+	s.Equal(currParams, defaultParams)
+	fullParams := partialParams.MergeOracleParams(defaultParams)
+	s.NotEqual(defaultParams, fullParams)
 
 	invalidSender := testutil.AccAddress()
 	oracleMsgServer := oraclekeeper.NewMsgServerImpl(nibiru.OracleKeeper)
 	goCtx := sdk.WrapSDKContext(ctx)
-	partialParams.Sender = invalidSender.String()
-	_, err := oracleMsgServer.EditOracleParams(
-		goCtx, &partialParams,
+	msgEditParams.Sender = invalidSender.String()
+	_, err = oracleMsgServer.EditOracleParams(
+		goCtx, &msgEditParams,
 	)
 	s.Error(err)
 
 	okSender := testapp.DefaultSudoRoot()
-	partialParams.Sender = okSender.String()
+	msgEditParams.Sender = okSender.String()
 	_, err = oracleMsgServer.EditOracleParams(
-		goCtx, &partialParams,
+		goCtx, &msgEditParams,
 	)
 	s.NoError(err)
-
-	// call admin method without err
 }