Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply LUT to any widget #1

Open
cbenhagen opened this issue Oct 22, 2019 · 4 comments
Open

Apply LUT to any widget #1

cbenhagen opened this issue Oct 22, 2019 · 4 comments

Comments

@cbenhagen
Copy link

I am especially interested in applying LUTs to video widgets.

@NiKoTron
Copy link
Owner

NiKoTron commented Oct 28, 2019

Hi, @cbenhagen ! It seems to be impossible at this time. Because we can't access the widget's representation byte array in the dart code. And at this time the performance of dart's code isn't enough for this one. sure for better performance, we can use ':ffi' package but it's absolutely different story... and the first problem still should be figured out.

In my opinion for a video widget, LUTs should be applied into the "native" part of code.

@tomasdev
Copy link

Interesting. On iOS this task is very simple (both in Swift and Obj-C) - I would dig up into Flutter Image lib maybe there is something there.

@cbenhagen
Copy link
Author

cbenhagen commented Apr 27, 2020

On iOS and macOS we could use the CIColorCube filter. But adding similar filters to all the native video players would be a pain or even impossible. Skia once had a SkColorCubeFilter but it has been removed. Maybe we could try to get this back in?

@cbenhagen
Copy link
Author

@NiKoTron / @tomasdev please vote for flutter/flutter#55738 by adding a 👍reaction to the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants