Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Styles enhancements poll #96

Open
delister opened this issue Oct 13, 2019 · 13 comments
Open

Styles enhancements poll #96

delister opened this issue Oct 13, 2019 · 13 comments
Milestone

Comments

@delister
Copy link

I think you need to increase the vertical indent between posts. And, as a result, also increase the indent between other people's posts.

If the message is short, then the distance between the messages of two people is enough and looks harmonious. But if the message is long, then the indentation is not enough, and the message of the next person begins to be perceived as a continuation of the current one. In addition, when the message is long and another message from the same person immediately falls under it, such a text is difficult to read. The upper line “squeezes”, and the gaze periodically rises.

In addition, I am convinced that it will look better.

This is a subjective opinion, it is necessary that others also speak out about this. Maybe it's possible to put it in a configuration file? So that everyone can adjust the indentation for themselves.

Name colors

Another improvement that I see is a change in the color of the names of the interlocutors. Now a case is possible when the name is difficult to read, due to the low contrast with the background. Maybe it's possible to change the color matching algorithm? or give the opportunity to specify a range of colors. Ideally, I would like to be able to include only 2 colors: one for my name, the other for all other names.

@deepbluev7
Copy link
Member

Message spacing

I think this one is very subjective. In my opinion, if you have a problem staying in one line when reading, this will still be an issue with longer messages that take multiple lines or maybe entire paragraphs. Increasing the spacing between messages wouldn't really solve that. I think limiting the line length or increasing line spacing would help that more. In my opinion there isn't really a difference of sending one message with 2 lines or two messages with one line, especially when it is pretty hard at the moment to send an image inside a normal text message.

A different approach to go at this, would be to add a background to each message, like other messengers do. This helps a lot more to distinct different messages and would also tie in with the second one of your points, as you could have two background colors. One for your messages, one for other messages.

Name colors

If the name colors don't have high enough contrast, we may need to look at the color algorithm again. It uses a contrast threshold, when generating the color, but it could be, that we are passing the wrong background color in or that the threshold is too low/buggy. Do you have an example, of where that is the case?

Also I'm currently experimenting with a timeline view written in qml in !91. That may make it easier to adapt any of your suggestions and make them configurable, but it also looks a bit different already. Also could you provide the platform your on and what theme you are using? It could also be, that the contrast is system/theme specific.

@delister
Copy link
Author

Message spacing

Yes, you are right, this is subjective, that's why I wanted to discuss and define it together. I also agree that line spacing is a more correct solution than indentation. But if you increase the line spacing, you will also have to increase the indentation between messages from different people, so that they visually separate. I mean, it will not be enough to change just the line spacing.

I switched from Riot and this is the first thing that caught my eye, maybe it's a matter of habit.

Regarding the background, if you mean something like a telegram, then I personally do not really like it, maybe most will like it more on the contrary.

Name colors

I use gentoo. Theme GTK2 ARC. Nheko Light theme.

For example, here it’s not convenient for me to read the name: xshram_original
Image of Yaktocat

and here: swedneck:permaweb.io
Image of Yaktocat

@deepbluev7
Copy link
Member

Message spacing

Of course an increased line spacing would also need an increased message spacing. But I wonder, do you think it is important to actually distinguish different messages? Usually I only need that, if the messages are sent on different days or id they are sent by different people, which is already taken care of by the date separators and user names before batches of messages. Currently they are inserted only every day or if the author changes, but that is easy to tweak.

I've always used the compact layout in Riot, which is a lot more similar to how nheko does it currently. We could maybe have a toggle like that, which changes avatar size, message spacing and maybe line spacing. We could also add visual separators in the non compact version between messages, i.e. a bit lighter/darker backround for each message and leaving the space between each message in the window colour. I.e.:

property compact layout non-compact layout
line spacing default 1.2x default
avatar size 32 48
message spacing normal line spacing/none height of one text line
color of space between messages no space -> none a bit lighter/darker than current background color? Username color? Something that looks good.

Name colors

Wow, those look amazingly hard to read! I haven't had that issue yet, but I'm mostly using the dark theme. Maybe our contrast code is broken for light backgrounds or maybe you can't make colours like yellow readable on light backgrounds. I'll try to verify that.

@delister
Copy link
Author

delister commented Oct 14, 2019

Name colors

Yes, the dark theme does not have such problems. While I will use it, thanks.

Message spacing

I don’t think it’s very important (to distinguish between messages), but I think that it will increase comfort, and to a greater extent it has a purely cosmetic function (again in my opinion).

And this idea with switching display modes, I really like. The only thing, I think that you should not increase the avatar, what do you think? Now he has opened a riot and watched how their mode switching works (compact and non-compact). In compact mode, only the indent between messages is reduced. Line height, avatar and everything else remains the same.

I also want to give an example of large messages from riot and nheko (this is the same message)
Nheko:
Nheko

Riot:
Nheko

This is what I said at the beginning that with a small line height, the text merges and is not very convenient to read. (The example is not entirely clean, because in riot indents between paragraphs are still implemented, but I think you understand what I mean)

I also think that in non-compact mode you should not select messages using the background color, only indentation will suffice. In my opinion this will be redundant.

@rnhmjoj
Copy link
Contributor

rnhmjoj commented Feb 26, 2020

Something that I don't like particularly are the new "options" and "reply" buttons that are always visible on the right of any message. IMHO they clutter interface and should only appear when then message is hovered/selected.

@deepbluev7
Copy link
Member

Yeah, that may be reasonable. It could also give us more space for the messages, although then it could also overlap with the message... Hm, I'll need to experiment with that.

@deepbluev7 deepbluev7 added this to the 0.7.1 milestone Apr 8, 2020
@InnayTool
Copy link

I think the spacing problem is not only in between the messages. The whole application could look and feel better if there would be added more space without "content", called negative space:

Considering and improving the balance between negative space and positive space in a composition is considered by many to enhance the design. This basic, but often overlooked, principle of design gives the eye a "place to rest," increasing the appeal of a composition through subtle means.

@vachan-maker
Copy link
Contributor

The text in the white boxes in the settings menu when dark mode is barely visible. Use of a different colour will probably solve the issue.

@duarm
Copy link
Contributor

duarm commented Mar 28, 2022

too many badges (edited, sent, trusted), and date
image
It would be nice to move all of those, at least the "trusted" and "sent" (although I would like to hide both of those) badges to the name row perhaps, and try to make the text row extend all the way to the window bounds. The per message info could be displayed when right clicking an specific message, or when:

  1. hovering an specific message.
  2. at the left side of the message, below the avatar, as that space is unused.

Although an option to hide each badge would already help.

@deepbluev7
Copy link
Member

If you use the bubbles layout, they are all below the message. I'm not that enthusiastic about hiding them, since I like seeing that info at a glance.

@duarm
Copy link
Contributor

duarm commented Mar 28, 2022

If you use the bubbles layout, they are all below the message

I don't like the bubble layout, but even the bubble layout does not extend to the edge of the window

I'm not that enthusiastic about hiding them, since I like seeing that info at a glance.

it could be displayed on that unused space below the avatar instead of shrinking the message.

@deepbluev7
Copy link
Member

There is no unused space with my font size though:

grafik

@duarm
Copy link
Contributor

duarm commented Mar 29, 2022

yeah, this change would require adjustments to the layout, but the goal is to extend the message as far as possible to the edge of the window, the badges just takes too much space for information I don't need most of the time, or I never need (sent/read badge).

The problem gets worse when on small screens and/or on narrow windows (mobile, tilling window managers)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants