Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI Release Github Action is tagging wrong branch #2087

Open
Al12rs opened this issue Sep 25, 2024 · 1 comment
Open

CI Release Github Action is tagging wrong branch #2087

Al12rs opened this issue Sep 25, 2024 · 1 comment
Labels
Bug Something isn't working Tech: CI

Comments

@Al12rs
Copy link
Contributor

Al12rs commented Sep 25, 2024

Bug Report

Summary

Release CI workflow is tagging main even when releasing from a different branch/commit.
The build happens on the desired branch correctly, but a tag is then pushed on main and the release linked to that tag.

Details

It seems softprops/action-gh-release@v1 should be updated to v2 and that we should provide it with target_commitish if we wish to push a tag on a different branch.

Fix would be to:

  • set target_commitish to the branch the workflow is being run on if it is not set
  • add optional target_commitish input to workflow to allow tagging a specific commit
    • Update the rest of the workflow to use the passed target commit if set, to create the build based on that instead of latest commit.
@Al12rs Al12rs added Bug Something isn't working Tech: CI labels Sep 25, 2024
@Sewer56
Copy link
Member

Sewer56 commented Sep 25, 2024

This happened this morning while publishing 0.6.1 for the record. We found out the hard way. Surprising this wasn't noticed before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Tech: CI
Projects
Status: No status
Development

No branches or pull requests

2 participants