Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 네비게이션 아이템 isHidden 수정 #100

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

haeseoklee
Copy link
Collaborator

🏗️ 구현사항

  • 미션을 생성했을때 미션 초대 코드가 방장 포함 모든 사람들에게 노출하도록 수정했습니다
  • 미션생성시 미션정보 버튼 노출되도록 수정했습니다

@haeseoklee haeseoklee self-assigned this Dec 19, 2024
Copy link
Collaborator

@longlivedrgn longlivedrgn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!~!👍

Comment on lines 34 to +35
}
.isHidden(
store.isMissionInfoGuideToolTipShowed || store.competition?.status != .created(hasOtherPlayer: true),
remove: true
)
.isHidden(store.isMissionInfoGuideToolTipShowed, remove: true)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

형 요거는 내가 그냥 궁금해서 그런데, 새롭게 정의된 isHidden 뷰빌더의 remove 파라미터는 무슨 용도야?!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

자기 자신을 layout에 포함시킬지 아닐지 결정하는 flag 변수입니다~
remove를 false로 두면 hidden 모디파이어를 붙이는데 이렇게 되면 화면에서 사라지지만 레이아웃은 그대로 유지하게 돼요

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] 방장이 아닌 사람도 초대코드 노출가능하도록 변경
2 participants