Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

form_pscis updates #119

Open
16 of 17 tasks
NewGraphEnvironment opened this issue Jun 23, 2023 · 5 comments
Open
16 of 17 tasks

form_pscis updates #119

NewGraphEnvironment opened this issue Jun 23, 2023 · 5 comments

Comments

@NewGraphEnvironment
Copy link
Owner

NewGraphEnvironment commented Jun 23, 2023

  • remove surveyor_* in favour of crew_members for simplicity
    • form_pscis
  • remove utm_corrected
    • form_pscis
  • remove habitat_comment but add detail to the assessment_comment
    • form_pscis
  • Add alias detail to gps_id and camera_id
  • Display checkbox state as a plain text values using Stored Values for *yes_no variables
  • pscis_crossing_id - don't enforce unique
  • swap in moti_chris_culvert_id for moti_culvert_id
  • background color for groups should be clear so we can view in QGIS when in night mode
  • remove default for utm zone
  • conditional groups match crossing_type input
  • embeddedment resemble_channel_yes_no to go in Embeddedment group
  • change the order of the habitat value to low med high
  • add a spot to take a photo of the completed card so that you back up the data and can easily cross reference.
    • form_pscis
@NewGraphEnvironment
Copy link
Owner Author

change attachment type for photo_card

@NewGraphEnvironment
Copy link
Owner Author

NewGraphEnvironment commented Sep 8, 2023

  • remove utm coordinate populating in form
  • No default to populate in embedded, fish observed and backwater fields

@NewGraphEnvironment
Copy link
Owner Author

NewGraphEnvironment commented Oct 26, 2023

  • add default value of "No" to all Yes/No fields such as beaver activity, fish presence, and embedment, to avoid NULL values
  • CBS numeric fields have NA values when user inputs a 0. Seen in outlet drop, outlet pool, culvert slope, and stream slope.
  • constraint on fill to less than 10m - with note to add to comments if diff.
  • constraint on length to less than 100m - with note to add to comments if diff.
  • add yes/nos for assess_type_phase1, assess_type_reassessment, assess_type_phase2 to simplify exports to pscis forms
  • fix date_time_stamp so that it is 24 hour clock
  • add the following columns with aliases
    moti_chris_culvert_id2 = NA_integer_,
    moti_chris_culvert_id3 = NA_integer_,
    my_priority = NA_character_, #need to think about this one. priority_follow_up_rank perhaps.
    my_citation_key1 = NA_character_,
    my_citation_key2 = NA_character_,
    my_citation_key3 = NA_character_
  • add column to tag if a UAV survey has been conducted at the site
  • change priority_notes to climate_priority_notes to avoid confusion

@NewGraphEnvironment
Copy link
Owner Author

NewGraphEnvironment commented Sep 4, 2024

still need to add latest checked items to .qgs files though. just in the qml right now

@NewGraphEnvironment
Copy link
Owner Author

default values should not happen when no value should land. see https://github.com/NewGraphEnvironment/fish_passage_template_reporting/issues/28#issuecomment-2365425609

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant